From 07ad39cba4004e658eb07a6afd3f12ac49660734 Mon Sep 17 00:00:00 2001
From: Zoltan Kochan <z@kochan.io>
Date: Sun, 10 May 2026 23:41:39 +0200
Subject: [PATCH] refactor: scope pm_on_fail override to the no-target-version
 branch

Only export `pnpm_config_pm_on_fail=download` when the action is relying on
bootstrap pnpm's runtime switch. When the user passes an explicit `version:`
input, self-update aligns the binary and we should not silently override their
`devEngines.packageManager.onFail = "error"` policy.
---
 dist/index.js           | Bin 1384773 -> 1384773 bytes
 src/install-pnpm/run.ts |  12 ++++++------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dist/index.js b/dist/index.js
index 4164ba5cd735d9e2faac217a7b31cc552648708f..dc6bc8785e61537fc8ea727349151e1309278c7c 100644
GIT binary patch
delta 68
zcmV~$$qj%Y5J1t0`!a~jRAU<y<l)z#RTwWO+(`&+`Cf`XMSoIYD5<DvXzAz~7?}_(
XGmeFojs4Rs!B~CFokfrEI=$QvGME-^

delta 78
zcmV~$xe0(k5I|A9&(-l5Y`{V+!h%G8W&xX<n+fJCi*5OycdK{nMnFhJOhQUVPC-dU
gjiI4M=;#?3Z~crtjZXFuouAL>71~8~d|uIAekJP}V*mgE

diff --git a/src/install-pnpm/run.ts b/src/install-pnpm/run.ts
index b8c3e6f..ffcf3b8 100644
--- a/src/install-pnpm/run.ts
+++ b/src/install-pnpm/run.ts
@@ -67,11 +67,6 @@ export async function runSelfInstaller(inputs: Inputs): Promise<SelfInstallerRes
   addPath(pnpmHome)
   addPath(path.join(pnpmHome, 'bin'))
   exportVariable('PNPM_HOME', pnpmHome)
-  // Force pnpm to honor manage-package-manager-versions even when the project
-  // pins `devEngines.packageManager.onFail = "error"`. Without this override
-  // the bootstrap pnpm errors with BAD_PM_VERSION instead of switching to the
-  // requested version on the user's first invocation (issue #252).
-  exportVariable('pnpm_config_pm_on_fail', 'download')
 
   // Ensure pnpm bin link exists — npm ci sometimes doesn't create it
   if (process.platform !== 'win32') {
@@ -107,7 +102,12 @@ export async function runSelfInstaller(inputs: Inputs): Promise<SelfInstallerRes
   }
 
   // No explicit target version: rely on the bootstrap pnpm to switch to
-  // the version declared in packageManager/devEngines at runtime.
+  // the version declared in packageManager/devEngines at runtime. Force
+  // `pmOnFail=download` so a project that pins
+  // `devEngines.packageManager.onFail = "error"` doesn't trip BAD_PM_VERSION
+  // before the switch can happen (issue #252). Scoped to this branch so users
+  // who pass an explicit `version:` input keep strict onFail behavior.
+  exportVariable('pnpm_config_pm_on_fail', 'download')
   return { exitCode: 0, binDest: pnpmHome }
 }