Compare commits

...

2 Commits

Author SHA1 Message Date
itchyny
e45710b5af
Merge 4e7ce9ad41 into 4a28cbc054 2024-07-31 17:26:58 +09:00
itchyny
4e7ce9ad41 Avoid re-evaluation of the key input in restore implementation 2024-04-14 22:44:33 +09:00
3 changed files with 3 additions and 7 deletions

View File

@ -59426,7 +59426,7 @@ function restoreImpl(stateProvider, earlyExit) {
} }
// Store the matched cache key in states // Store the matched cache key in states
stateProvider.setState(constants_1.State.CacheMatchedKey, cacheKey); stateProvider.setState(constants_1.State.CacheMatchedKey, cacheKey);
const isExactKeyMatch = utils.isExactKeyMatch(core.getInput(constants_1.Inputs.Key, { required: true }), cacheKey); const isExactKeyMatch = utils.isExactKeyMatch(primaryKey, cacheKey);
core.setOutput(constants_1.Outputs.CacheHit, isExactKeyMatch.toString()); core.setOutput(constants_1.Outputs.CacheHit, isExactKeyMatch.toString());
if (lookupOnly) { if (lookupOnly) {
core.info(`Cache found and can be restored from key: ${cacheKey}`); core.info(`Cache found and can be restored from key: ${cacheKey}`);

View File

@ -59426,7 +59426,7 @@ function restoreImpl(stateProvider, earlyExit) {
} }
// Store the matched cache key in states // Store the matched cache key in states
stateProvider.setState(constants_1.State.CacheMatchedKey, cacheKey); stateProvider.setState(constants_1.State.CacheMatchedKey, cacheKey);
const isExactKeyMatch = utils.isExactKeyMatch(core.getInput(constants_1.Inputs.Key, { required: true }), cacheKey); const isExactKeyMatch = utils.isExactKeyMatch(primaryKey, cacheKey);
core.setOutput(constants_1.Outputs.CacheHit, isExactKeyMatch.toString()); core.setOutput(constants_1.Outputs.CacheHit, isExactKeyMatch.toString());
if (lookupOnly) { if (lookupOnly) {
core.info(`Cache found and can be restored from key: ${cacheKey}`); core.info(`Cache found and can be restored from key: ${cacheKey}`);

View File

@ -69,11 +69,7 @@ export async function restoreImpl(
// Store the matched cache key in states // Store the matched cache key in states
stateProvider.setState(State.CacheMatchedKey, cacheKey); stateProvider.setState(State.CacheMatchedKey, cacheKey);
const isExactKeyMatch = utils.isExactKeyMatch( const isExactKeyMatch = utils.isExactKeyMatch(primaryKey, cacheKey);
core.getInput(Inputs.Key, { required: true }),
cacheKey
);
core.setOutput(Outputs.CacheHit, isExactKeyMatch.toString()); core.setOutput(Outputs.CacheHit, isExactKeyMatch.toString());
if (lookupOnly) { if (lookupOnly) {
core.info(`Cache found and can be restored from key: ${cacheKey}`); core.info(`Cache found and can be restored from key: ${cacheKey}`);