Merge 3ec6195bfc into 1f36f5b7a2

Merge pull request #789 from docker/dependabot/npm_and_yarn/aws-sdk-dependencies-6be6d766e7
build(deps): bump the aws-sdk-dependencies group across 1 directory with 2 updates
2026-07-07 17:45:36 +00:00 · 2024-10-10 13:57:20 +08:00 · 2024-10-04 12:18:45 +02:00 · 2024-10-04 12:16:17 +02:00 · 2024-10-04 05:07:07 +00:00 · 2024-10-02 14:33:21 +02:00
5 changed files with 681 additions and 661 deletions
--- a/README.md
+++ b/README.md
@ -52,7 +52,7 @@ jobs:
        name: Login to Docker Hub
        uses: docker/login-action@v3
        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          username: ${{ vars.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}
 ```

@ -106,7 +106,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: registry.gitlab.com
-          username: ${{ secrets.GITLAB_USERNAME }}
+          username: ${{ vars.GITLAB_USERNAME }}
          password: ${{ secrets.GITLAB_PASSWORD }}
 ```

@ -137,7 +137,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: <registry-name>.azurecr.io
-          username: ${{ secrets.AZURE_CLIENT_ID }}
+          username: ${{ vars.AZURE_CLIENT_ID }}
          password: ${{ secrets.AZURE_CLIENT_SECRET }}
 ```

@ -200,8 +200,7 @@ jobs:
 Use a service account with permission to push to GCR and [configure access control](https://cloud.google.com/container-registry/docs/access-control).
 Download the key for the service account as a JSON file. Save the contents of
 the file [as a secret](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#creating-encrypted-secrets-for-a-repository)
-named `GCR_JSON_KEY` in your GitHub repository. Set the username to `_json_key`,
-or `_json_key_base64` if you use a base64-encoded key.
+named `GCR_JSON_KEY` in your GitHub repository. Set the username to `_json_key`.

 ```yaml
 name: ci
@ -323,7 +322,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: <aws-account-number>.dkr.ecr.<region>.amazonaws.com
-          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          username: ${{ vars.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
 ```

@ -346,7 +345,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: <aws-account-number>.dkr.ecr.<region>.amazonaws.com
-          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          username: ${{ vars.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        env:
          AWS_ACCOUNT_IDS: 012345678910,023456789012
@ -372,7 +371,7 @@ jobs:
        name: Configure AWS Credentials
        uses: aws-actions/configure-aws-credentials@v4
        with:
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws-access-key-id: ${{ vars.AWS_ACCESS_KEY_ID }}
          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
          aws-region: <region>
      -
@ -407,7 +406,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: public.ecr.aws
-          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          username: ${{ vars.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        env:
          AWS_REGION: <region>
@ -441,7 +440,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: <region>.ocir.io
-          username: ${{ secrets.OCI_USERNAME }}
+          username: ${{ vars.OCI_USERNAME }}
          password: ${{ secrets.OCI_TOKEN }}
 ```

@ -468,7 +467,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: quay.io
-          username: ${{ secrets.QUAY_USERNAME }}
+          username: ${{ vars.QUAY_USERNAME }}
          password: ${{ secrets.QUAY_ROBOT_TOKEN }}
 ```

@ -492,7 +491,7 @@ jobs:
        uses: docker/login-action@v3
        with:
          registry: registry.digitalocean.com
-          username: ${{ secrets.DIGITALOCEAN_USERNAME }}
+          username: ${{ vars.DIGITALOCEAN_USERNAME }}
          password: ${{ secrets.DIGITALOCEAN_ACCESS_TOKEN }}
 ```

--- a/dist/index.js
+++ b/dist/index.js
--- a/dist/index.js.map
+++ b/dist/index.js.map
--- a/package.json
+++ b/package.json
@ -26,8 +26,8 @@
  "packageManager": "yarn@3.6.3",
  "dependencies": {
    "@actions/core": "^1.10.1",
-    "@aws-sdk/client-ecr": "^3.583.0",
-    "@aws-sdk/client-ecr-public": "^3.583.0",
+    "@aws-sdk/client-ecr": "^3.664.0",
+    "@aws-sdk/client-ecr-public": "^3.664.0",
    "@docker/actions-toolkit": "^0.35.0",
    "http-proxy-agent": "^7.0.2",
    "https-proxy-agent": "^7.0.5"
--- a/yarn.lock
+++ b/yarn.lock
Author	SHA1	Message	Date
Omachonu Ogali	bb2b698497	Merge `3ec6195bfc` into `1f36f5b7a2`	2024-10-10 13:57:20 +08:00
CrazyMax	1f36f5b7a2	Merge pull request #789 from docker/dependabot/npm_and_yarn/aws-sdk-dependencies-6be6d766e7 build(deps): bump the aws-sdk-dependencies group across 1 directory with 2 updates	2024-10-04 12:18:45 +02:00
CrazyMax	bcb47c2c49	chore: update generated content Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>	2024-10-04 12:16:17 +02:00
dependabot[bot]	8165a5b270	build(deps): bump the aws-sdk-dependencies group across 1 directory with 2 updates Bumps the aws-sdk-dependencies group with 2 updates in the / directory: [@aws-sdk/client-ecr](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-ecr) and [@aws-sdk/client-ecr-public](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-ecr-public). Updates `@aws-sdk/client-ecr` from 3.583.0 to 3.664.0 - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-ecr/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.664.0/clients/client-ecr) Updates `@aws-sdk/client-ecr-public` from 3.583.0 to 3.664.0 - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-ecr-public/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.664.0/clients/client-ecr-public) --- updated-dependencies: - dependency-name: "@aws-sdk/client-ecr" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-dependencies - dependency-name: "@aws-sdk/client-ecr-public" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-04 05:07:07 +00:00
CrazyMax	29df2a9f8c	Merge pull request #787 from docker/fix-readme-examples README: fix gcr example, use vars for usernames	2024-10-02 14:33:21 +02:00
David Karlsson	2b0e0e02ba	docs: use vars for usernames, not secrets Using vars for insensitive data is preferred since secrets are redacted from e.g. build summary Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>	2024-10-02 14:29:58 +02:00
David Karlsson	fe7fd06c5d	docs: gcr does not support base64-encoded keys Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>	2024-10-02 14:15:12 +02:00