A filter rule that mixed positive and bare negation patterns under the
default ('some') predicate quantifier matched nearly every file in a PR.
Each pattern was compiled into its own picomatch matcher and combined
via Array.prototype.some, so a standalone '!**/*.md' (true for any
non-markdown file) flipped the whole rule into a near-universal match.
Group bare string patterns into a single matcher with gitignore-style
semantics: a file matches when it matches at least one positive pattern
and does not match any negation pattern. The 'every' quantifier path is
unchanged, since per-pattern matching under .every() already produces
correct subtractive semantics with negations. The '!(extglob)' single-
string form is preserved by detecting only '!' not followed by '('.
Apply the same gitignore-style grouping to status-tagged array patterns
so 'added: ["src/**", "!**/*.md"]' behaves correctly. Reject rules made
up entirely of negation patterns (no positive include) so the failure
is loud rather than a silent permanent no-match.
Closesdorny/paths-filter#260
Setting the new 'predicate-quantifier' configuration parameter to 'every'
makes it so that all the patterns have to match a file for it to be
considered changed.
This can be leveraged to ensure that you only build & test software changes
that have real impact on the behavior of the code, e.g. you can set up your
build to run when Typescript/Rust/etc. files are changed but markdown
changes in the diff will be ignored and you consume less resources to build.
The default behavior does not change by the introduction of this feature
so upgrading can be done safely knowing that existing workflows will not
break.
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This adds support for using multiple patterns when checking for file status (added, modified, deleted) and as a result also allows you to use YAML anchors.
* Use micromatch instead of minimatch
micromatch claims to support full Bash 4.3 spec and it actually passes all the tests.
For example this fixes processing of '!(**/*.tsx|**/*.less)' pattern - needed by #45
* Update CHANGELOG.md
* Avoid code repetition with exec() and output listeners
* Improve behavior for new branches and when it's running in ACT
* Detect parent commit only if needed
* Fix parent commit detection for initial commit
* Improve logging
* Improve current ref detection
* Fix issue when base is a already fetched tag
* Fix issue when base is a already fetched tag
* Update README
* Document usage with act
* Use `git log` to get changes in latest commit
* Disable other output for `git log`
* get short name from base ref + improve loggig
* update CHANGELOG
* Rework change detection via `git diff`
Previous implementation performed simple diff between two versions. New implementation fetches on demand more commits to have the merge base between two branches. Now it will detect only changes introduced by branch that was pushed, instead of mixing with changes introduced meanwhile on the base branch.
* Add support for specification of change type (add,modified,delete)
* Use NULL as separator in git-diff command output
* Improve PR test workflow
* Fix the workflow file
* Add support for nested arrays of path expressions
* Remove pull_request trigger type options
Default value is fine: opened, synchronize, reopened
* Add CHANGELOG
* Update README
* Enable minimatch dot option
It's not a default globbing behavior, however for our use-case is much more convenient to match those files.
* Update README and package.json
* Remove accidental string interpolation from action.yml
* Fix test workflow filters
* Improve self-test
* Add test case for matching any changed file
* Fix workflow test - step `name` was used instead of `id`
* Extend default pull_request trigger types
* Remove `edited` trigger to avoid executing workflow on non-code changes
