actions/setup-java
1
0
Fork 0
mirror of https://github.com/actions/setup-java.git synced 2026-03-27 14:40:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(tests): update error messages for version not found scenarios

Browse Source
This commit is contained in:
chiranjib-swain 2026-03-24 17:25:40 +05:30
parent 102c2095e0
commit 421e43bf5a
19 changed files with 34 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
__tests__/distributors/adopt-installer.test.ts
View File

@ -268,7 +268,7 @@ describe('findPackageForDownload', () => {
distribution['getAvailableVersions'] = async () => manifestData as any; distribution['getAvailableVersions'] = async () => manifestData as any;
await expect( await expect(
distribution['findPackageForDownload']('9.0.8') distribution['findPackageForDownload']('9.0.8')
).rejects.toThrow(/Could not find satisfied version for SemVer */); ).rejects.toThrow(/No matching version found for SemVer */);
}); });
it('version is not found', async () => { it('version is not found', async () => {
@ -283,7 +283,7 @@ describe('findPackageForDownload', () => {
); );
distribution['getAvailableVersions'] = async () => manifestData as any; distribution['getAvailableVersions'] = async () => manifestData as any;
await expect(distribution['findPackageForDownload']('7.x')).rejects.toThrow( await expect(distribution['findPackageForDownload']('7.x')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
@ -299,7 +299,7 @@ describe('findPackageForDownload', () => {
); );
distribution['getAvailableVersions'] = async () => []; distribution['getAvailableVersions'] = async () => [];
await expect(distribution['findPackageForDownload']('11')).rejects.toThrow( await expect(distribution['findPackageForDownload']('11')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
}); });

8
__tests__/distributors/base-installer.test.ts
View File

@ -538,7 +538,7 @@ describe('setupJava', () => {
])('should throw an error for version not found for %s', async input => { ])('should throw an error for version not found for %s', async input => {
mockJavaBase = new EmptyJavaBase(input); mockJavaBase = new EmptyJavaBase(input);
await expect(mockJavaBase.setupJava()).rejects.toThrow( await expect(mockJavaBase.setupJava()).rejects.toThrow(
`Could not find satisfied version for SemVer '${input.version}'` `No matching version found for SemVer '${input.version}'`
); );
expect(spyTcFindAllVersions).toHaveBeenCalled(); expect(spyTcFindAllVersions).toHaveBeenCalled();
expect(spyCoreAddPath).not.toHaveBeenCalled(); expect(spyCoreAddPath).not.toHaveBeenCalled();
@ -584,7 +584,7 @@ describe('createVersionNotFoundError', () => {
const error = (mockJavaBase as any).createVersionNotFoundError('17.0.5'); const error = (mockJavaBase as any).createVersionNotFoundError('17.0.5');
expect(error.message).toContain( expect(error.message).toContain(
"Could not find satisfied version for SemVer '17.0.5'" "No matching version found for SemVer '17.0.5'"
); );
expect(error.message).toContain('Distribution: Empty'); expect(error.message).toContain('Distribution: Empty');
expect(error.message).toContain('Package type: jdk'); expect(error.message).toContain('Package type: jdk');
@ -606,7 +606,7 @@ describe('createVersionNotFoundError', () => {
); );
expect(error.message).toContain( expect(error.message).toContain(
"Could not find satisfied version for SemVer '17.0.5'" "No matching version found for SemVer '17.0.5'"
); );
expect(error.message).toContain('Distribution: Empty'); expect(error.message).toContain('Distribution: Empty');
expect(error.message).toContain('Package type: jdk'); expect(error.message).toContain('Package type: jdk');
@ -653,7 +653,7 @@ describe('createVersionNotFoundError', () => {
); );
expect(error.message).toContain( expect(error.message).toContain(
"Could not find satisfied version for SemVer '17.0.5'" "No matching version found for SemVer '17.0.5'"
); );
expect(error.message).toContain('Distribution: Empty'); expect(error.message).toContain('Distribution: Empty');
expect(error.message).toContain('Package type: jdk'); expect(error.message).toContain('Package type: jdk');

2
__tests__/distributors/corretto-installer.test.ts
View File

@ -203,7 +203,7 @@ describe('getAvailableVersions', () => {
await expect( await expect(
distribution['findPackageForDownload'](version) distribution['findPackageForDownload'](version)
).rejects.toThrow("Could not find satisfied version for SemVer '4'"); ).rejects.toThrow("No matching version found for SemVer '4'");
}); });
it.each([ it.each([

2
__tests__/distributors/dragonwell-installer.test.ts
View File

@ -238,7 +238,7 @@ describe('getAvailableVersions', () => {
await expect( await expect(
distribution['findPackageForDownload'](jdkVersion) distribution['findPackageForDownload'](jdkVersion)
).rejects.toThrow( ).rejects.toThrow(
`Could not find satisfied version for SemVer '${jdkVersion}'` `No matching version found for SemVer '${jdkVersion}'`
); );
} }
); );

8
__tests__/distributors/graalvm-installer.test.ts
View File

@ -356,9 +356,7 @@ describe('GraalVMDistribution', () => {
// Verify the error is thrown with the expected message // Verify the error is thrown with the expected message
await expect( await expect(
(distribution as any).findPackageForDownload('17.0.99') (distribution as any).findPackageForDownload('17.0.99')
).rejects.toThrow( ).rejects.toThrow("No matching version found for SemVer '17.0.99'");
"Could not find satisfied version for SemVer '17.0.99'"
);
// Verify the hint about checking the base URL is included // Verify the hint about checking the base URL is included
await expect( await expect(
@ -508,7 +506,7 @@ describe('GraalVMDistribution', () => {
await expect( await expect(
(distribution as any).findPackageForDownload('23') (distribution as any).findPackageForDownload('23')
).rejects.toThrow( ).rejects.toThrow(
"No EA build is marked as 'latest' for version range '23-ea'. Available EA versions: 23-ea-20240716." "No EA build is marked as latest for version '23-ea'. Available EA versions: ['23-ea-20240716']."
); );
// Verify error logging - removed as we now use the helper method which doesn't call core.error // Verify error logging - removed as we now use the helper method which doesn't call core.error
@ -719,7 +717,7 @@ describe('GraalVMDistribution', () => {
await expect( await expect(
(distribution as any).findEABuildDownloadUrl('23-ea') (distribution as any).findEABuildDownloadUrl('23-ea')
).rejects.toThrow( ).rejects.toThrow(
"No EA build is marked as 'latest' for version range '23-ea'. Available EA versions: 23-ea-20240716, 23-ea-20240709." "No EA build is marked as latest for version '23-ea'. Available EA versions: ['23-ea-20240716', '23-ea-20240709']."
); );
// Verify error logging - removed as we now use the helper method which doesn't call core.error // Verify error logging - removed as we now use the helper method which doesn't call core.error

4
__tests__/distributors/jetbrains-installer.test.ts
View File

@ -104,7 +104,7 @@ describe('findPackageForDownload', () => {
}); });
distribution['getAvailableVersions'] = async () => manifestData as any; distribution['getAvailableVersions'] = async () => manifestData as any;
await expect(distribution['findPackageForDownload']('8.x')).rejects.toThrow( await expect(distribution['findPackageForDownload']('8.x')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
@ -117,7 +117,7 @@ describe('findPackageForDownload', () => {
}); });
distribution['getAvailableVersions'] = async () => []; distribution['getAvailableVersions'] = async () => [];
await expect(distribution['findPackageForDownload']('8')).rejects.toThrow( await expect(distribution['findPackageForDownload']('8')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
}); });

2
__tests__/distributors/liberica-installer.test.ts
View File

@ -215,7 +215,7 @@ describe('findPackageForDownload', () => {
it('should throw an error', async () => { it('should throw an error', async () => {
await expect(distribution['findPackageForDownload']('17')).rejects.toThrow( await expect(distribution['findPackageForDownload']('17')).rejects.toThrow(
/Could not find satisfied version for SemVer/ /No matching version found for SemVer/
); );
}); });
}); });

2
__tests__/distributors/liberica-linux-installer.test.ts
View File

@ -215,7 +215,7 @@ describe('findPackageForDownload', () => {
it('should throw an error', async () => { it('should throw an error', async () => {
await expect(distribution['findPackageForDownload']('18')).rejects.toThrow( await expect(distribution['findPackageForDownload']('18')).rejects.toThrow(
/Could not find satisfied version for SemVer/ /No matching version found for SemVer/
); );
}); });
}); });

2
__tests__/distributors/liberica-windows-installer.test.ts
View File

@ -214,7 +214,7 @@ describe('findPackageForDownload', () => {
it('should throw an error', async () => { it('should throw an error', async () => {
await expect(distribution['findPackageForDownload']('18')).rejects.toThrow( await expect(distribution['findPackageForDownload']('18')).rejects.toThrow(
/Could not find satisfied version for SemVer/ /No matching version found for SemVer/
); );
}); });
}); });

2
__tests__/distributors/microsoft-installer.test.ts
View File

@ -179,7 +179,7 @@ describe('findPackageForDownload', () => {
it('should throw an error', async () => { it('should throw an error', async () => {
await expect(distribution['findPackageForDownload']('8')).rejects.toThrow( await expect(distribution['findPackageForDownload']('8')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
}); });

2
__tests__/distributors/sapmachine-installer.test.ts
View File

@ -272,7 +272,7 @@ describe('getAvailableVersions', () => {
await expect( await expect(
distribution['findPackageForDownload'](normalizedVersion) distribution['findPackageForDownload'](normalizedVersion)
).rejects.toThrow( ).rejects.toThrow(
`Could not find satisfied version for SemVer '${normalizedVersion}'` `No matching version found for SemVer '${normalizedVersion}'`
); );
} }
); );

6
__tests__/distributors/semeru-installer.test.ts
View File

@ -157,7 +157,7 @@ describe('findPackageForDownload', () => {
distribution['getAvailableVersions'] = async () => manifestData as any; distribution['getAvailableVersions'] = async () => manifestData as any;
await expect( await expect(
distribution['findPackageForDownload']('9.0.8') distribution['findPackageForDownload']('9.0.8')
).rejects.toThrow(/Could not find satisfied version for SemVer */); ).rejects.toThrow(/No matching version found for SemVer */);
}); });
it('version is not found', async () => { it('version is not found', async () => {
@ -169,7 +169,7 @@ describe('findPackageForDownload', () => {
}); });
distribution['getAvailableVersions'] = async () => manifestData as any; distribution['getAvailableVersions'] = async () => manifestData as any;
await expect(distribution['findPackageForDownload']('7.x')).rejects.toThrow( await expect(distribution['findPackageForDownload']('7.x')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
@ -182,7 +182,7 @@ describe('findPackageForDownload', () => {
}); });
distribution['getAvailableVersions'] = async () => []; distribution['getAvailableVersions'] = async () => [];
await expect(distribution['findPackageForDownload']('8')).rejects.toThrow( await expect(distribution['findPackageForDownload']('8')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });

6
__tests__/distributors/temurin-installer.test.ts
View File

@ -218,7 +218,7 @@ describe('findPackageForDownload', () => {
distribution['getAvailableVersions'] = async () => manifestData as any; distribution['getAvailableVersions'] = async () => manifestData as any;
await expect( await expect(
distribution['findPackageForDownload']('9.0.8') distribution['findPackageForDownload']('9.0.8')
).rejects.toThrow(/Could not find satisfied version for SemVer */); ).rejects.toThrow(/No matching version found for SemVer */);
}); });
it('version is not found', async () => { it('version is not found', async () => {
@ -233,7 +233,7 @@ describe('findPackageForDownload', () => {
); );
distribution['getAvailableVersions'] = async () => manifestData as any; distribution['getAvailableVersions'] = async () => manifestData as any;
await expect(distribution['findPackageForDownload']('7.x')).rejects.toThrow( await expect(distribution['findPackageForDownload']('7.x')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
@ -249,7 +249,7 @@ describe('findPackageForDownload', () => {
); );
distribution['getAvailableVersions'] = async () => []; distribution['getAvailableVersions'] = async () => [];
await expect(distribution['findPackageForDownload']('8')).rejects.toThrow( await expect(distribution['findPackageForDownload']('8')).rejects.toThrow(
/Could not find satisfied version for SemVer */ /No matching version found for SemVer */
); );
}); });
}); });

2
__tests__/distributors/zulu-installer.test.ts
View File

@ -231,6 +231,6 @@ describe('findPackageForDownload', () => {
distribution['getAvailableVersions'] = async () => manifestData; distribution['getAvailableVersions'] = async () => manifestData;
await expect( await expect(
distribution['findPackageForDownload'](distribution['version']) distribution['findPackageForDownload'](distribution['version'])
).rejects.toThrow(/Could not find satisfied version for SemVer/); ).rejects.toThrow(/No matching version found for SemVer/);
}); });
}); });

2
__tests__/distributors/zulu-linux-installer.test.ts
View File

@ -234,6 +234,6 @@ describe('findPackageForDownload', () => {
distribution['getAvailableVersions'] = async () => manifestData; distribution['getAvailableVersions'] = async () => manifestData;
await expect( await expect(
distribution['findPackageForDownload'](distribution['version']) distribution['findPackageForDownload'](distribution['version'])
).rejects.toThrow(/Could not find satisfied version for SemVer/); ).rejects.toThrow(/No matching version found for SemVer/);
}); });
}); });

2
__tests__/distributors/zulu-windows-installer.test.ts
View File

@ -232,6 +232,6 @@ describe('findPackageForDownload', () => {
distribution['getAvailableVersions'] = async () => manifestData; distribution['getAvailableVersions'] = async () => manifestData;
await expect( await expect(
distribution['findPackageForDownload'](distribution['version']) distribution['findPackageForDownload'](distribution['version'])
).rejects.toThrow(/Could not find satisfied version for SemVer/); ).rejects.toThrow(/No matching version found for SemVer/);
}); });
}); });

6
dist/setup/index.js vendored
View File

@ -112571,7 +112571,7 @@ class JavaBase {
} }
createVersionNotFoundError(versionOrRange, availableVersions, additionalContext) { createVersionNotFoundError(versionOrRange, availableVersions, additionalContext) {
const parts = [ const parts = [
`Could not find satisfied version for SemVer '${versionOrRange}'.`, `No matching version found for SemVer '${versionOrRange}'.`,
`Distribution: ${this.distribution}`, `Distribution: ${this.distribution}`,
`Package type: ${this.packageType}`, `Package type: ${this.packageType}`,
`Architecture: ${this.architecture}` `Architecture: ${this.architecture}`
@ -113238,9 +113238,9 @@ class GraalVMDistribution extends base_installer_1.JavaBase {
const latestVersion = versions.find(v => v.latest); const latestVersion = versions.find(v => v.latest);
if (!latestVersion) { if (!latestVersion) {
const availableVersions = versions.map(v => v.version); const availableVersions = versions.map(v => v.version);
let message = `No EA build is marked as 'latest' for version range '${javaEaVersion}'.`; let message = `No EA build is marked as latest for version '${javaEaVersion}'.`;
if (availableVersions.length > 0) { if (availableVersions.length > 0) {
message += ` Available EA versions: ${availableVersions.join(', ')}.`; message += ` Available EA versions: [${availableVersions.map(v => `'${v}'`).join(', ')}].`;
} }
throw new Error(message); throw new Error(message);
} }

2
src/distributions/base-installer.ts
View File

@ -265,7 +265,7 @@ export abstract class JavaBase {
additionalContext?: string additionalContext?: string
): Error { ): Error {
const parts = [ const parts = [
`Could not find satisfied version for SemVer '${versionOrRange}'.`, `No matching version found for SemVer '${versionOrRange}'.`,
`Distribution: ${this.distribution}`, `Distribution: ${this.distribution}`,
`Package type: ${this.packageType}`, `Package type: ${this.packageType}`,
`Architecture: ${this.architecture}` `Architecture: ${this.architecture}`

4
src/distributions/graalvm/installer.ts
View File

@ -182,9 +182,9 @@ export class GraalVMDistribution extends JavaBase {
const latestVersion = versions.find(v => v.latest); const latestVersion = versions.find(v => v.latest);
if (!latestVersion) { if (!latestVersion) {
const availableVersions = versions.map(v => v.version); const availableVersions = versions.map(v => v.version);
let message = `No EA build is marked as 'latest' for version range '${javaEaVersion}'.`; let message = `No EA build is marked as latest for version '${javaEaVersion}'.`;
if (availableVersions.length > 0) { if (availableVersions.length > 0) {
message += ` Available EA versions: ${availableVersions.join(', ')}.`; message += ` Available EA versions: [${availableVersions.map(v => `'${v}'`).join(', ')}].`;
} }
throw new Error(message); throw new Error(message);
} }