From aa2ee0a47508b3e66f2c6f499787134e901e3f13 Mon Sep 17 00:00:00 2001 From: guicamest <283778+guicamest@users.noreply.github.com> Date: Sat, 25 Jan 2025 22:02:44 +0100 Subject: [PATCH] feat: Add support for `.sdkmanrc` as *Java Version File* --- __tests__/util.test.ts | 17 +++++++++++++++++ dist/cleanup/index.js | 3 +++ dist/setup/index.js | 3 +++ src/util.ts | 2 ++ 4 files changed, 25 insertions(+) diff --git a/__tests__/util.test.ts b/__tests__/util.test.ts index 9c943c2..c96e6ae 100644 --- a/__tests__/util.test.ts +++ b/__tests__/util.test.ts @@ -2,6 +2,7 @@ import * as cache from '@actions/cache'; import * as core from '@actions/core'; import { convertVersionToSemver, + getVersionFromFileContent, isVersionSatisfies, isCacheFeatureAvailable, isGhes @@ -82,6 +83,22 @@ describe('convertVersionToSemver', () => { }); }); +describe('getVersionFromFileContent', () => { + describe('.sdkmanrc', () => { + it.each([ + ['java=11.0.20.1-tem', '11.0.20'], + ['java = 11.0.20.1-tem', '11.0.20'], + ['java=11.0.20.1-tem # a comment in sdkmanrc', '11.0.20'], + ['java=11.0.20.1-tem\n#java=21.0.20.1-tem\n', '11.0.20'], // choose first match + ['java=11.0.20.1-tem\njava=21.0.20.1-tem\n', '11.0.20'], // choose first match + ['#java=11.0.20.1-tem\njava=21.0.20.1-tem\n', '21.0.20'] // first one is 'commented' in .sdkmanrc + ])('parsing %s should return %s', (content: string, expected: string) => { + const actual = getVersionFromFileContent(content, 'openjdk', '.sdkmanrc'); + expect(actual).toBe(expected); + }); + }); +}); + describe('isGhes', () => { const pristineEnv = process.env; diff --git a/dist/cleanup/index.js b/dist/cleanup/index.js index 5ac78e7..d87452d 100644 --- a/dist/cleanup/index.js +++ b/dist/cleanup/index.js @@ -97069,6 +97069,9 @@ function getVersionFromFileContent(content, distributionName, versionFile) { javaVersionRegExp = /^(java\s+)(?:\S*-)?v?(?(\d+)(\.\d+)?(\.\d+)?(\+\d+)?(-ea(\.\d+)?)?)$/m; } + else if (versionFileName == '.sdkmanrc') { + javaVersionRegExp = /^java\s*=\s*(?[^-]+)/m; + } else { javaVersionRegExp = /(?(?<=(^|\s|-))(\d+\S*))(\s|$)/; } diff --git a/dist/setup/index.js b/dist/setup/index.js index 6e6e205..e9c81a4 100644 --- a/dist/setup/index.js +++ b/dist/setup/index.js @@ -135074,6 +135074,9 @@ function getVersionFromFileContent(content, distributionName, versionFile) { javaVersionRegExp = /^(java\s+)(?:\S*-)?v?(?(\d+)(\.\d+)?(\.\d+)?(\+\d+)?(-ea(\.\d+)?)?)$/m; } + else if (versionFileName == '.sdkmanrc') { + javaVersionRegExp = /^java\s*=\s*(?[^-]+)/m; + } else { javaVersionRegExp = /(?(?<=(^|\s|-))(\d+\S*))(\s|$)/; } diff --git a/src/util.ts b/src/util.ts index af75aaa..559a7fe 100644 --- a/src/util.ts +++ b/src/util.ts @@ -134,6 +134,8 @@ export function getVersionFromFileContent( if (versionFileName == '.tool-versions') { javaVersionRegExp = /^(java\s+)(?:\S*-)?v?(?(\d+)(\.\d+)?(\.\d+)?(\+\d+)?(-ea(\.\d+)?)?)$/m; + } else if (versionFileName == '.sdkmanrc') { + javaVersionRegExp = /^java\s*=\s*(?[^-]+)/m; } else { javaVersionRegExp = /(?(?<=(^|\s|-))(\d+\S*))(\s|$)/; }