mirror of
https://github.com/actions/setup-java.git
synced 2026-06-16 16:38:50 +00:00
b24df5bba5
* Make the Adoptopenjdk package type look at the Temurin repo first for latest assets
* Address Copilot code review comments
- Use strict equality (===, !==) instead of loose equality (==, !=) for all comparisons
- Properly handle caught errors with instanceof type narrowing before accessing properties
- Only fall back to legacy AdoptOpenJDK for specific version-not-found errors
- Rethrow unexpected errors to avoid masking real issues (network failures, rate limits, etc.)
- Fix error message check to match actual error text ('No matching version found')
- Remove unnecessary undefined check since method return type is never undefined
- Add @internal JSDoc annotation to TemurinDistribution.findPackageForDownload()
- Update tests to properly mock Temurin lookup failures for fallback behavior testing
- Rebuild dist files
* Always fall back to legacy AdoptOpenJDK but log all Temurin failures
- Change error handling to gracefully fall back for all errors, not just version-not-found
- Log version-not-found errors as notices with migration guidance
- Log other Temurin failures as debug messages for troubleshooting
- Improves resilience: users always get a result even if Temurin API has issues
- Maintains visibility: failures are still logged for debugging
* Fixes from review
* Fixes from review
* Fixes from review
* Regenerate dist
|
||
|---|---|---|
| .. | ||
| adopt-installer.test.ts | ||
| base-installer.test.ts | ||
| corretto-installer.test.ts | ||
| dragonwell-installer.test.ts | ||
| graalvm-installer.test.ts | ||
| jetbrains-installer.test.ts | ||
| liberica-installer.test.ts | ||
| liberica-linux-installer.test.ts | ||
| liberica-windows-installer.test.ts | ||
| local-installer.test.ts | ||
| microsoft-installer.test.ts | ||
| oracle-installer.test.ts | ||
| sapmachine-installer.test.ts | ||
| semeru-installer.test.ts | ||
| temurin-installer.test.ts | ||
| zulu-installer.test.ts | ||
| zulu-linux-installer.test.ts | ||
| zulu-windows-installer.test.ts | ||