__tests__/main.test.ts

@@ -13,10 +13,6 @@ import each from 'jest-each';
 import * as main from '../src/main';
 import * as util from '../src/util';
 import OfficialBuilds from '../src/distributions/official_builds/official_builds';
-import * as installerFactory from '../src/distributions/installer-factory';
-jest.mock('../src/distributions/installer-factory', () => ({
-  getNodejsDistribution: jest.fn()
-}));
 
 describe('main tests', () => {
   let inputs = {} as any;
@@ -285,125 +281,3 @@ describe('main tests', () => {
     });
   });
 });
-
-
-// Mock the necessary modules
-jest.mock('@actions/core');
-jest.mock('./distributions/installer-factory');
-
-// Create a mock object that satisfies the BaseDistribution type
-const createMockNodejsDistribution = () => ({
-  setupNodeJs: jest.fn(),
-  // Mocking other properties required by the BaseDistribution type (adjust based on your actual types)
-  httpClient: {}, // Example for httpClient, replace with proper mock if necessary
-  osPlat: 'darwin', // Example platform ('darwin', 'win32', 'linux', etc.)
-  nodeInfo: {
-    version: '14.x',
-    arch: 'x64',
-    platform: 'darwin',
-  },
-  getDistributionUrl: jest.fn().mockReturnValue('https://nodejs.org/dist/'), // Default distribution URL
-  install: jest.fn(),
-  validate: jest.fn(),
-  // Mock any other methods/properties defined in BaseDistribution
-});
-
-// Define the mock structure for BaseDistribution type (adjust to your actual type)
-interface BaseDistribution {
-  setupNodeJs: jest.Mock;
-  httpClient: object;
-  osPlat: string;
-  nodeInfo: {
-    version: string;
-    arch: string;
-    platform: string;
-  };
-  getDistributionUrl: jest.Mock;
-  install: jest.Mock;
-  validate: jest.Mock;
-}
-
-describe('Mirror URL Tests', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
-  it('should pass mirror URL correctly when provided', async () => {
-    (core.getInput as jest.Mock).mockImplementation((name: string) => {
-      if (name === 'mirror-url') return 'https://custom-mirror-url.com';
-      if (name === 'node-version') return '14.x';
-      return '';
-    });
-
-    const mockNodejsDistribution = createMockNodejsDistribution();
-    (installerFactory.getNodejsDistribution as unknown as jest.Mock<typeof installerFactory.getNodejsDistribution>).mockReturnValue(mockNodejsDistribution);
-
-    await main.run();
-
-    // Ensure setupNodeJs is called with the correct parameters, including the mirror URL
-    expect(mockNodejsDistribution.setupNodeJs).toHaveBeenCalledWith({
-      versionSpec: '14.x',
-      checkLatest: false,
-      auth: undefined,
-      stable: true,
-      arch: 'x64',
-      mirrorURL: 'https://custom-mirror-url.com',
-    });
-  });
-
-  it('should use default mirror URL when no mirror URL is provided', async () => {
-    (core.getInput as jest.Mock).mockImplementation((name: string) => {
-      if (name === 'mirror-url') return '';
-      if (name === 'node-version') return '14.x';
-      return '';
-    });
-
-    const mockNodejsDistribution = createMockNodejsDistribution();
-    (installerFactory.getNodejsDistribution as jest.Mock).mockReturnValue(mockNodejsDistribution);
-
-    await main.run();
-
-    // Expect that setupNodeJs is called with an empty mirror URL (which will default inside the function)
-    expect(mockNodejsDistribution.setupNodeJs).toHaveBeenCalledWith(expect.objectContaining({
-      mirrorURL: '', // Default URL is expected to be handled internally
-    }));
-  });
-
-  it('should handle mirror URL with spaces correctly', async () => {
-    (core.getInput as jest.Mock).mockImplementation((name: string) => {
-      if (name === 'mirror-url') return '    https://custom-mirror-url.com   ';
-      if (name === 'node-version') return '14.x';
-      return '';
-    });
-
-    const mockNodejsDistribution = createMockNodejsDistribution();
-    (installerFactory.getNodejsDistribution as jest.Mock).mockReturnValue(mockNodejsDistribution);
-
-    await main.run();
-
-    // Expect that setupNodeJs is called with the trimmed mirror URL
-    expect(mockNodejsDistribution.setupNodeJs).toHaveBeenCalledWith(expect.objectContaining({
-      mirrorURL: 'https://custom-mirror-url.com',
-    }));
-  });
-
-  it('should warn if architecture is provided but node-version is missing', async () => {
-    (core.getInput as jest.Mock).mockImplementation((name: string) => {
-      if (name === 'architecture') return 'x64';
-      if (name === 'node-version') return '';
-      return '';
-    });
-
-    const mockWarning = jest.spyOn(core, 'warning');
-    const mockNodejsDistribution = createMockNodejsDistribution();
-    installerFactory.getNodejsDistribution.mockReturnValue(mockNodejsDistribution);
-
-    await main.run();
-
-    expect(mockWarning).toHaveBeenCalledWith(
-      '`architecture` is provided but `node-version` is missing. In this configuration, the version/architecture of Node will not be changed.'
-    );
-    expect(mockNodejsDistribution.setupNodeJs).not.toHaveBeenCalled(); // Setup Node should not be called
-  });
-});
-

__tests__/nightly-installer.test.ts

@@ -10,8 +10,8 @@ import osm from 'os';
 import path from 'path';
 import * as main from '../src/main';
 import * as auth from '../src/authutil';
-import {INodeVersion, NodeInputs} from '../src/distributions/base-models';
+import {INodeVersion} from '../src/distributions/base-models';
-import NightlyNodejs from '../src/distributions/nightly/nightly_builds';
+
 import nodeTestManifest from './data/versions-manifest.json';
 import nodeTestDist from './data/node-dist-index.json';
 import nodeTestDistNightly from './data/node-nightly-index.json';
@@ -606,95 +606,3 @@ describe('setup-node', () => {
     );
   });
 });
-// Mock core.info to track the log output
-jest.mock('@actions/core', () => ({
-  info: jest.fn(),
-}));
-
-// Create a subclass to access the protected method for testing purposes
-class TestNightlyNodejs extends NightlyNodejs {
-  public getDistributionUrlPublic() {
-    return this.getDistributionUrl();  // This allows us to call the protected method
-  }
-}
-
-describe('NightlyNodejs', () => {
-
-  it('uses mirror URL when provided', async () => {
-    const mirrorURL = 'https://my.custom.mirror/nodejs/nightly';
-    const nodeInfo: NodeInputs = {
-      mirrorURL: '', versionSpec: '18.0.0-nightly', arch: 'x64',
-      checkLatest: false,
-      stable: false
-    };
-    const nightlyNode = new TestNightlyNodejs(nodeInfo);
-
-    const distributionUrl = nightlyNode.getDistributionUrlPublic();
-    
-    expect(distributionUrl).toBe(mirrorURL);
-    expect(core.info).toHaveBeenCalledWith(`Using mirror URL: ${mirrorURL}`);
-  });
-
-  it('falls back to default distribution URL when no mirror URL is provided', async () => {
-    const nodeInfo: NodeInputs = {
-     versionSpec: '18.0.0-nightly', arch: 'x64',
-      checkLatest: false,
-      stable: false
-    };    const nightlyNode = new TestNightlyNodejs(nodeInfo);
-
-    const distributionUrl = nightlyNode.getDistributionUrlPublic();
-
-    expect(distributionUrl).toBe('https://nodejs.org/download/nightly');
-    expect(core.info).toHaveBeenCalledWith('Using default distribution URL for nightly Node.js.');
-  });
-
-  it('logs mirror URL when provided', async () => {
-    const mirrorURL = 'https://custom.mirror/nodejs/nightly';
-    const nodeInfo: NodeInputs = {
-      mirrorURL: '', versionSpec: '18.0.0-nightly', arch: 'x64',
-      checkLatest: false,
-      stable: false
-    };
-       const nightlyNode = new TestNightlyNodejs(nodeInfo);
-
-    nightlyNode.getDistributionUrlPublic();
-    
-    expect(core.info).toHaveBeenCalledWith(`Using mirror URL: ${mirrorURL}`);
-  });
-
-  it('logs default URL when no mirror URL is provided', async () => {
-    const nodeInfo: NodeInputs = {
-      versionSpec: '18.0.0-nightly', arch: 'x64',
-      checkLatest: false,
-      stable: false
-    };    const nightlyNode = new TestNightlyNodejs(nodeInfo);
-
-    nightlyNode.getDistributionUrlPublic();
-
-    expect(core.info).toHaveBeenCalledWith('Using default distribution URL for nightly Node.js.');
-  });
-
-  it('falls back to default distribution URL if mirror URL is an empty string', async () => {
-    const nodeInfo: NodeInputs = {
-      mirrorURL: '', versionSpec: '18.0.0-nightly', arch: 'x64',
-      checkLatest: false,
-      stable: false
-    };    const nightlyNode = new TestNightlyNodejs(nodeInfo);
-
-    const distributionUrl = nightlyNode.getDistributionUrlPublic();
-
-    expect(distributionUrl).toBe('https://nodejs.org/download/nightly');
-    expect(core.info).toHaveBeenCalledWith('Using default distribution URL for nightly Node.js.');
-  });
-
-  it('falls back to default distribution URL if mirror URL is undefined', async () => {
-    const nodeInfo: NodeInputs = { nodeVersion: '18.0.0-nightly', architecture: 'x64', platform: 'linux' };
-    const nightlyNode = new TestNightlyNodejs(nodeInfo);
-
-    const distributionUrl = nightlyNode.getDistributionUrlPublic();
-
-    expect(distributionUrl).toBe('https://nodejs.org/download/nightly');
-    expect(core.info).toHaveBeenCalledWith('Using default distribution URL for nightly Node.js.');
-  });
-
-});

__tests__/official-installer.test.ts

@@ -829,101 +829,3 @@ describe('setup-node', () => {
     );
   });
 });
-describe('OfficialBuilds - Mirror URL functionality', () => {
-  const nodeInfo: NodeInputs = { nodeVersion: '18.0.0-nightly', architecture: 'x64', platform: 'linux', mirrorURL: '' };
-  
-  it('should download using the mirror URL when provided', async () => {
-    const mirrorURL = 'https://my.custom.mirror/nodejs';
-    nodeInfo.mirrorURL = mirrorURL;
-    const officialBuilds = new OfficialBuilds(nodeInfo);
-
-    // Mock download from mirror URL
-    const mockDownloadPath = '/some/temp/path';
-    jest.spyOn(tc, 'downloadTool').mockResolvedValue(mockDownloadPath);
-
-    await officialBuilds.setupNodeJs();
-
-    expect(core.info).toHaveBeenCalledWith('Attempting to download using mirror URL...');
-    expect(core.info).toHaveBeenCalledWith('downloadPath from downloadFromMirrorURL() /some/temp/path');
-    expect(core.addPath).toHaveBeenCalledWith(mockDownloadPath);
-  });
-
-  it('should log a message when mirror URL is used', async () => {
-    const mirrorURL = 'https://my.custom.mirror/nodejs';
-    nodeInfo.mirrorURL = mirrorURL;
-    const officialBuilds = new OfficialBuilds(nodeInfo);
-
-    const mockDownloadPath = '/some/temp/path';
-    jest.spyOn(tc, 'downloadTool').mockResolvedValue(mockDownloadPath);
-
-    await officialBuilds.setupNodeJs();
-
-    expect(core.info).toHaveBeenCalledWith(`Using mirror URL: ${mirrorURL}`);
-  });
-
-  it('should fall back to default URL if mirror URL is not provided', async () => {
-    nodeInfo.mirrorURL = ''; // No mirror URL provided
-    const officialBuilds = new OfficialBuilds(nodeInfo);
-
-    const mockDownloadPath = '/some/temp/path';
-    jest.spyOn(tc, 'downloadTool').mockResolvedValue(mockDownloadPath);
-
-    await officialBuilds.setupNodeJs();
-
-    expect(core.info).toHaveBeenCalledWith('Attempting to download from default Node.js URL...');
-    expect(core.addPath).toHaveBeenCalledWith(mockDownloadPath);
-  });
-
-  it('should log an error and handle failure during mirror URL download', async () => {
-    const mirrorURL = 'https://my.custom.mirror/nodejs';
-    nodeInfo.mirrorURL = mirrorURL;
-    const officialBuilds = new OfficialBuilds(nodeInfo);
-
-    // Simulate an error during the download process
-    const errorMessage = 'Network error';
-    jest.spyOn(tc, 'downloadTool').mockRejectedValue(new Error(errorMessage));
-
-    await officialBuilds.setupNodeJs();
-
-    expect(core.info).toHaveBeenCalledWith('Attempting to download using mirror URL...');
-    expect(core.error).toHaveBeenCalledWith(errorMessage);
-    expect(core.debug).toHaveBeenCalledWith(expect.stringContaining('empty stack'));
-  });
-
-  it('should log a fallback message if downloading from the mirror URL fails', async () => {
-    const mirrorURL = 'https://my.custom.mirror/nodejs';
-    nodeInfo.mirrorURL = mirrorURL;
-    const officialBuilds = new OfficialBuilds(nodeInfo);
-
-    // Simulate download failure and fallback to default URL
-    const errorMessage = 'Network error';
-    jest.spyOn(tc, 'downloadTool').mockRejectedValue(new Error(errorMessage));
-
-    const mockDownloadPath = '/some/temp/path';
-    jest.spyOn(tc, 'downloadTool').mockResolvedValue(mockDownloadPath);
-
-    await officialBuilds.setupNodeJs();
-
-    expect(core.info).toHaveBeenCalledWith('Failed to download from mirror URL. Falling back to default Node.js URL...');
-    expect(core.addPath).toHaveBeenCalledWith(mockDownloadPath);
-  });
-
-  it('should throw an error if mirror URL is not provided and downloading from both mirror and default fails', async () => {
-    nodeInfo.mirrorURL = ''; // No mirror URL
-    const officialBuilds = new OfficialBuilds(nodeInfo);
-
-    // Simulate failure in both mirror and default download
-    const errorMessage = 'Network error';
-    jest.spyOn(tc, 'downloadTool').mockRejectedValue(new Error(errorMessage));
-
-    await expect(officialBuilds.setupNodeJs()).rejects.toThrowError(new Error('Unable to find Node version for platform linux and architecture x64.'));
-  });
-
-  it('should throw an error if mirror URL is undefined and not provided', async () => {
-    nodeInfo.mirrorURL = undefined; // Undefined mirror URL
-    const officialBuilds = new OfficialBuilds(nodeInfo);
-
-    // Simulate a missing mirror URL scenario
-    await expect(officialBuilds.setupNodeJs()).rejects.toThrowError('Mirror URL is undefined');
-  });
-});

dist/setup/index.js

@@ -100154,14 +100154,6 @@ class BaseDistribution {
             return response.result || [];
         });
     }
-    getMirrorUrlVersions() {
-        return __awaiter(this, void 0, void 0, function* () {
-            const initialUrl = this.getDistributionMirrorUrl();
-            const dataUrl = `${initialUrl}/index.json`;
-            const response = yield this.httpClient.getJson(dataUrl);
-            return response.result || [];
-        });
-    }
     getNodejsDistInfo(version) {
         const osArch = this.translateArchToDistUrl(this.nodeInfo.arch);
         version = semver_1.default.clean(version) || '';
@@ -100173,7 +100165,7 @@ class BaseDistribution {
                 ? `${fileName}.zip`
                 : `${fileName}.7z`
             : `${fileName}.tar.gz`;
-        const initialUrl = this.getDistributionMirrorUrl();
+        const initialUrl = this.getDistributionUrl();
         const url = `${initialUrl}/v${version}/${urlFileName}`;
         return {
             downloadUrl: url,
@@ -100414,54 +100406,17 @@ exports.getNodejsDistribution = getNodejsDistribution;
 
 "use strict";
 
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 const base_distribution_prerelease_1 = __importDefault(__nccwpck_require__(957));
-const core = __importStar(__nccwpck_require__(2186));
 class NightlyNodejs extends base_distribution_prerelease_1.default {
     constructor(nodeInfo) {
         super(nodeInfo);
         this.distribution = 'nightly';
     }
-    getDistributionMirrorUrl() {
-        // Implement the method to return the mirror URL or an empty string if not available
-        return this.nodeInfo.mirrorURL || '';
-    }
-    // Updated getDistributionUrl method to handle mirror URL or fallback
     getDistributionUrl() {
-        // Check if mirrorUrl exists in the nodeInfo and return it if available
-        const mirrorUrl = this.nodeInfo.mirrorURL;
-        if (mirrorUrl) {
-            core.info(`Using mirror URL: ${mirrorUrl}`);
-            return mirrorUrl;
-        }
-        // Default to the official Node.js nightly distribution URL if no mirror URL is provided
-        core.info('Using default distribution URL for nightly Node.js.');
         return 'https://nodejs.org/download/nightly';
     }
 }
@@ -100528,7 +100483,6 @@ class OfficialBuilds extends base_distribution_1.default {
                 try {
                     core.info(`Attempting to download using mirror URL...`);
                     downloadPath = yield this.downloadFromMirrorURL(); // Attempt to download from the mirror
-                    core.info('downloadPath from downloadFromMirrorURL() ' + downloadPath);
                     if (downloadPath) {
                         toolPath = downloadPath;
                     }
@@ -100649,13 +100603,6 @@ class OfficialBuilds extends base_distribution_1.default {
     getDistributionUrl() {
         return `https://nodejs.org/dist`;
     }
-    getDistributionMirrorUrl() {
-        const mirrorURL = this.nodeInfo.mirrorURL;
-        if (!mirrorURL) {
-            throw new Error('Mirror URL is undefined');
-        }
-        return mirrorURL;
-    }
     getManifest() {
         core.debug('Getting manifest from actions/node-versions@main');
         return tc.getManifestFromRepo('actions', 'node-versions', this.nodeInfo.auth, 'main');
@@ -100723,9 +100670,17 @@ class OfficialBuilds extends base_distribution_1.default {
     }
     downloadFromMirrorURL() {
         return __awaiter(this, void 0, void 0, function* () {
-            const nodeJsVersions = yield this.getMirrorUrlVersions();
+            const nodeJsVersions = yield this.getNodeJsVersions();
+            core.info('versions from nodeJSVersions' + nodeJsVersions);
             const versions = this.filterVersions(nodeJsVersions);
+            core.info('versions' + versions);
             const evaluatedVersion = this.evaluateVersions(versions);
+            core.info('versionSpec' + this.nodeInfo.versionSpec);
+            if (this.nodeInfo.checkLatest) {
+                const evaluatedVersion = yield this.findVersionInDist(nodeJsVersions);
+                this.nodeInfo.versionSpec = evaluatedVersion;
+                core.info('versionSpec' + this.nodeInfo.versionSpec);
+            }
             if (!evaluatedVersion) {
                 throw new Error(`Unable to find Node version '${this.nodeInfo.versionSpec}' for platform ${this.osPlat} and architecture ${this.nodeInfo.arch}.`);
             }
@@ -100759,35 +100714,11 @@ exports["default"] = OfficialBuilds;
 
 "use strict";
 
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 const base_distribution_1 = __importDefault(__nccwpck_require__(7));
-const core = __importStar(__nccwpck_require__(2186));
 class RcBuild extends base_distribution_1.default {
     constructor(nodeInfo) {
         super(nodeInfo);
@@ -100795,16 +100726,6 @@ class RcBuild extends base_distribution_1.default {
     getDistributionUrl() {
         return 'https://nodejs.org/download/rc';
     }
-    getDistributionMirrorUrl() {
-        // Check if mirrorUrl exists in the nodeInfo and return it if available
-        const mirrorUrl = this.nodeInfo.mirrorURL;
-        if (mirrorUrl) {
-            core.info(`Using mirror URL: ${mirrorUrl}`);
-            return mirrorUrl;
-        }
-        // Return the default URL if no mirror URL is provided
-        return this.getDistributionUrl();
-    }
 }
 exports["default"] = RcBuild;
 
@@ -100816,35 +100737,11 @@ exports["default"] = RcBuild;
 
 "use strict";
 
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 const base_distribution_prerelease_1 = __importDefault(__nccwpck_require__(957));
-const core = __importStar(__nccwpck_require__(2186));
 class CanaryBuild extends base_distribution_prerelease_1.default {
     constructor(nodeInfo) {
         super(nodeInfo);
@@ -100853,15 +100750,6 @@ class CanaryBuild extends base_distribution_prerelease_1.default {
     getDistributionUrl() {
         return 'https://nodejs.org/download/v8-canary';
     }
-    getDistributionMirrorUrl() {
-        // Check if mirrorUrl exists in the nodeInfo and return it if available
-        const mirrorUrl = this.nodeInfo.mirrorURL;
-        if (mirrorUrl) {
-            core.info(`Using mirror URL: ${mirrorUrl}`);
-            return mirrorUrl;
-        }
-        return 'https://nodejs.org/download/v8-canary';
-    }
 }
 exports["default"] = CanaryBuild;
 

src/distributions/base-distribution.ts

@@ -25,7 +25,7 @@ export default abstract class BaseDistribution {
   }
 
   protected abstract getDistributionUrl(): string;
-  protected abstract getDistributionMirrorUrl(): string;
+  
 
   public async setupNodeJs() {
     let nodeJsVersions: INodeVersion[] | undefined;
@@ -105,15 +105,6 @@ export default abstract class BaseDistribution {
     return response.result || [];
   }
 
-  protected async getMirrorUrlVersions(): Promise<INodeVersion[]> {
-    const initialUrl = this.getDistributionMirrorUrl();
-    
-    const dataUrl = `${initialUrl}/index.json`;
-
-    const response = await this.httpClient.getJson<INodeVersion[]>(dataUrl);
-    return response.result || [];
-  }
-
   protected getNodejsDistInfo(version: string) {
     const osArch: string = this.translateArchToDistUrl(this.nodeInfo.arch);
     version = semver.clean(version) || '';
@@ -127,7 +118,7 @@ export default abstract class BaseDistribution {
           ? `${fileName}.zip`
           : `${fileName}.7z`
         : `${fileName}.tar.gz`;
-    const initialUrl = this.getDistributionMirrorUrl();
+    const initialUrl = this.getDistributionUrl();
     const url = `${initialUrl}/v${version}/${urlFileName}`;
 
     return <INodeVersionInfo>{
@@ -140,9 +131,7 @@ export default abstract class BaseDistribution {
 
   protected getNodejsMirrorURLInfo(version: string) {
     const mirrorURL = this.nodeInfo.mirrorURL;
-    
     const osArch: string = this.translateArchToDistUrl(this.nodeInfo.arch);
-    
     version = semver.clean(version) || '';
     const fileName: string =
       this.osPlat == 'win32'
@@ -184,9 +173,7 @@ export default abstract class BaseDistribution {
           info.downloadUrl
         );
       }
-      core.error(
+      core.error(`Download failed from ${info.downloadUrl}. Please check the URl and try again.`);
-        `Download failed from ${info.downloadUrl}. Please check the URl and try again.`
-      );
 
       throw err;
     }
@@ -208,7 +195,7 @@ export default abstract class BaseDistribution {
   protected async acquireWindowsNodeFromFallbackLocation(
     version: string,
     arch: string = os.arch(),
-    downloadUrl: string
+    downloadUrl : string
   ): Promise<string> {
     const initialUrl = this.getDistributionUrl();
     core.info('url: ' + initialUrl);
@@ -227,12 +214,8 @@ export default abstract class BaseDistribution {
       libUrl = `${initialUrl}/v${version}/win-${osArch}/node.lib`;
 
       core.info(`Downloading only node binary from ${exeUrl}`);
+      if(downloadUrl != exeUrl ){core.error('unable to download node binary with the provided URL. Please check and try again');}
       
-      if (downloadUrl != exeUrl) {
-        core.error(
-          'unable to download node binary with the provided URL. Please check and try again'
-        );
-      }
 
       const exePath = await tc.downloadTool(exeUrl);
       await io.cp(exePath, path.join(tempDir, 'node.exe'));

src/distributions/base-models.ts

@@ -4,7 +4,7 @@ export interface NodeInputs {
   auth?: string;
   checkLatest: boolean;
   stable: boolean;
-  mirrorURL?: string;
+  mirrorURL: string;
 }
 
 export interface INodeVersionInfo {
@@ -12,6 +12,7 @@ export interface INodeVersionInfo {
   resolvedVersion: string;
   arch: string;
   fileName: string;
+  
 }
 
 export interface INodeVersion {

src/distributions/nightly/nightly_builds.ts

@@ -1,31 +1,13 @@
 import BasePrereleaseNodejs from '../base-distribution-prerelease';
 import {NodeInputs} from '../base-models';
-import * as core from '@actions/core';
 
 export default class NightlyNodejs extends BasePrereleaseNodejs {
-  
   protected distribution = 'nightly';
-
   constructor(nodeInfo: NodeInputs) {
     super(nodeInfo);
   }
 
-  protected getDistributionMirrorUrl(): string {
-    // Implement the method to return the mirror URL or an empty string if not available
-    return this.nodeInfo.mirrorURL || '';
-  }
-
-  // Updated getDistributionUrl method to handle mirror URL or fallback
   protected getDistributionUrl(): string {
-    // Check if mirrorUrl exists in the nodeInfo and return it if available
-    const mirrorUrl = this.nodeInfo.mirrorURL;
-    if (mirrorUrl) {
-      core.info(`Using mirror URL: ${mirrorUrl}`);
-      return mirrorUrl;
-    }
-
-    // Default to the official Node.js nightly distribution URL if no mirror URL is provided
-    core.info('Using default distribution URL for nightly Node.js.');
     return 'https://nodejs.org/download/nightly';
   }
 }

src/distributions/official_builds/official_builds.ts

@@ -12,16 +12,18 @@ interface INodeRelease extends tc.IToolRelease {
 export default class OfficialBuilds extends BaseDistribution {
   constructor(nodeInfo: NodeInputs) {
     super(nodeInfo);
+    
   }
   
+
   public async setupNodeJs() {
-    if (this.nodeInfo.mirrorURL) {
+     if(this.nodeInfo.mirrorURL){
+
       let downloadPath = '';
       let toolPath = '';
          try {
            core.info(`Attempting to download using mirror URL...`);
            downloadPath = await this.downloadFromMirrorURL(); // Attempt to download from the mirror
-        core.info('downloadPath from downloadFromMirrorURL() '+ downloadPath);
             if (downloadPath) {
              toolPath = downloadPath;
            }
@@ -29,7 +31,8 @@ export default class OfficialBuilds extends BaseDistribution {
            core.info((err as Error).message);
            core.debug((err as Error).stack ?? 'empty stack');
          }
-    } else {
+      
+     }else{
     let manifest: tc.IToolRelease[] | undefined;
     let nodeJsVersions: INodeVersion[] | undefined;
     const osArch = this.translateArchToDistUrl(this.nodeInfo.arch);
@@ -140,7 +143,8 @@ export default class OfficialBuilds extends BaseDistribution {
 
     core.addPath(toolPath);
   }
-  }
+}
+
 
   protected addToolPath(toolPath: string) {
     if (this.osPlat != 'win32') {
@@ -196,13 +200,6 @@ export default class OfficialBuilds extends BaseDistribution {
     return `https://nodejs.org/dist`;
   }
 
-  protected getDistributionMirrorUrl(): string {
-    const mirrorURL = this.nodeInfo.mirrorURL;
-    if (!mirrorURL) {
-      throw new Error('Mirror URL is undefined');
-    }
-    return mirrorURL;
-  }
  
   private getManifest(): Promise<tc.IToolRelease[]> {
     core.debug('Getting manifest from actions/node-versions@main');
@@ -317,13 +314,20 @@ export default class OfficialBuilds extends BaseDistribution {
   }
 
   protected async downloadFromMirrorURL() {
-    const nodeJsVersions = await this.getMirrorUrlVersions();
+    const nodeJsVersions = await this.getNodeJsVersions();
+    core.info('versions from nodeJSVersions'+nodeJsVersions);
     const versions = this.filterVersions(nodeJsVersions);
-
+    core.info('versions'+versions);
 
     const evaluatedVersion = this.evaluateVersions(versions);
+    core.info('versionSpec'+this.nodeInfo.versionSpec);
     
+    if (this.nodeInfo.checkLatest) {
+      const evaluatedVersion = await this.findVersionInDist(nodeJsVersions);
+      this.nodeInfo.versionSpec = evaluatedVersion;
+      core.info('versionSpec'+this.nodeInfo.versionSpec);
       
+    }
 
     if (!evaluatedVersion) {
       throw new Error(
@@ -333,11 +337,8 @@ export default class OfficialBuilds extends BaseDistribution {
 
     const toolName = this.getNodejsMirrorURLInfo(evaluatedVersion);
 
-
-
     try {
       const toolPath = await this.downloadNodejs(toolName);
-
       return toolPath;
     } catch (error) {
       if (error instanceof tc.HTTPError && error.httpStatusCode === 404) {
@@ -354,4 +355,5 @@ export default class OfficialBuilds extends BaseDistribution {
       throw error;
     }
   }
+
 }

src/distributions/rc/rc_builds.ts

@@ -1,9 +1,7 @@
 import BaseDistribution from '../base-distribution';
 import {NodeInputs} from '../base-models';
-import * as core from '@actions/core';
 
 export default class RcBuild extends BaseDistribution {
-
   constructor(nodeInfo: NodeInputs) {
     super(nodeInfo);
   }
@@ -11,16 +9,4 @@ export default class RcBuild extends BaseDistribution {
   getDistributionUrl(): string {
     return 'https://nodejs.org/download/rc';
   }
-
-  protected getDistributionMirrorUrl(): string {
-    // Check if mirrorUrl exists in the nodeInfo and return it if available
-    const mirrorUrl = this.nodeInfo.mirrorURL;
-    if (mirrorUrl) {
-      core.info(`Using mirror URL: ${mirrorUrl}`);
-      return mirrorUrl;
-    }
-
-    // Return the default URL if no mirror URL is provided
-    return this.getDistributionUrl();
-  }
 }

src/distributions/v8-canary/canary_builds.ts

@@ -1,8 +1,7 @@
 import BasePrereleaseNodejs from '../base-distribution-prerelease';
 import {NodeInputs} from '../base-models';
-import * as core from '@actions/core';
-export default class CanaryBuild extends BasePrereleaseNodejs {
 
+export default class CanaryBuild extends BasePrereleaseNodejs {
   protected distribution = 'v8-canary';
   constructor(nodeInfo: NodeInputs) {
     super(nodeInfo);
@@ -11,14 +10,4 @@ export default class CanaryBuild extends BasePrereleaseNodejs {
   protected getDistributionUrl(): string {
     return 'https://nodejs.org/download/v8-canary';
   }
-
-  protected getDistributionMirrorUrl(): string {
-    // Check if mirrorUrl exists in the nodeInfo and return it if available
-    const mirrorUrl = this.nodeInfo.mirrorURL;
-    if (mirrorUrl) {
-      core.info(`Using mirror URL: ${mirrorUrl}`);
-      return mirrorUrl;
-    }
-    return 'https://nodejs.org/download/v8-canary';
-  }
 }

src/main.ts

@@ -35,6 +35,7 @@ export async function run() {
 
     const mirrorURL = core.getInput('mirror-url').trim(); // .trim() to remove any accidental spaces
 
+
     if (version) {
       const token = core.getInput('token');
       const auth = !token ? undefined : `token ${token}`;