Merge 43811dd6bd into d86ebcd40b

README.md

@@ -103,7 +103,7 @@ The `node-version` input supports the Semantic Versioning Specification, for mor
 
 Examples:
 
- - Major versions: `18`, `20`
+ - Major versions: `16`, `18`, `20`
  - More specific versions: `10.15`, `16.15.1` , `18.4.0`
  - NVM LTS syntax: `lts/erbium`, `lts/fermium`, `lts/*`, `lts/-n`
  - Latest release: `*` or `latest`/`current`/`node`
@@ -135,7 +135,7 @@ steps:
 - uses: actions/checkout@v4
 - uses: actions/setup-node@v4
   with:
-    node-version: 20
+    node-version: 16
     cache: 'npm'
 - run: npm ci
 - run: npm test
@@ -148,7 +148,7 @@ steps:
 - uses: actions/checkout@v4
 - uses: actions/setup-node@v4
   with:
-    node-version: 20
+    node-version: 16
     cache: 'npm'
     cache-dependency-path: subdir/package-lock.json
 - run: npm ci
@@ -185,7 +185,7 @@ To get a higher rate limit, you can [generate a personal access token on github.
 uses: actions/setup-node@v4
 with:
   token: ${{ secrets.GH_DOTCOM_TOKEN }}
-  node-version: 20
+  node-version: 16
 ```
 
 If the runner is not able to access github.com, any Nodejs versions requested during a workflow run must come from the runner's tool cache. See "[Setting up the tool cache on self-hosted runners without internet access](https://docs.github.com/en/enterprise-server@3.2/admin/github-actions/managing-access-to-actions-from-githubcom/setting-up-the-tool-cache-on-self-hosted-runners-without-internet-access)" for more information.

__tests__/main.test.ts

@@ -2,7 +2,6 @@ import * as core from '@actions/core';
 import * as exec from '@actions/exec';
 import * as tc from '@actions/tool-cache';
 import * as cache from '@actions/cache';
-import * as io from '@actions/io';
 
 import fs from 'fs';
 import path from 'path';
@@ -25,10 +24,6 @@ describe('main tests', () => {
   let startGroupSpy: jest.SpyInstance;
   let endGroupSpy: jest.SpyInstance;
 
-  let whichSpy: jest.SpyInstance;
-
-  let existsSpy: jest.SpyInstance;
-
   let getExecOutputSpy: jest.SpyInstance;
 
   let getNodeVersionFromFileSpy: jest.SpyInstance;
@@ -60,8 +55,6 @@ describe('main tests', () => {
     inSpy = jest.spyOn(core, 'getInput');
     inSpy.mockImplementation(name => inputs[name]);
 
-    whichSpy = jest.spyOn(io, 'which');
-
     getExecOutputSpy = jest.spyOn(exec, 'getExecOutput');
 
     findSpy = jest.spyOn(tc, 'find');
@@ -147,10 +140,6 @@ describe('main tests', () => {
         return {stdout: obj[command], stderr: '', exitCode: 0};
       });
 
-      whichSpy.mockImplementation(cmd => {
-        return `some/${cmd}/path`;
-      });
-
       await util.printEnvDetailsAndSetOutput();
 
       expect(setOutputSpy).toHaveBeenCalledWith('node-version', obj['node']);

__tests__/official-installer.test.ts

@@ -248,9 +248,6 @@ describe('setup-node', () => {
     const toolPath = path.normalize('/cache/node/12.16.2/x64');
     exSpy.mockImplementation(async () => '/some/other/temp/path');
     cacheSpy.mockImplementation(async () => toolPath);
-    whichSpy.mockImplementation(cmd => {
-      return `some/${cmd}/path`;
-    });
 
     await main.run();
 

dist/cache-save/index.js

@@ -83336,7 +83336,6 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.unique = exports.printEnvDetailsAndSetOutput = exports.getNodeVersionFromFile = void 0;
 const core = __importStar(__nccwpck_require__(2186));
 const exec = __importStar(__nccwpck_require__(1514));
-const io = __importStar(__nccwpck_require__(7436));
 const fs_1 = __importDefault(__nccwpck_require__(7147));
 const path_1 = __importDefault(__nccwpck_require__(1017));
 function getNodeVersionFromFile(versionFilePath) {
@@ -83388,8 +83387,7 @@ function printEnvDetailsAndSetOutput() {
     return __awaiter(this, void 0, void 0, function* () {
         core.startGroup('Environment details');
         const promises = ['node', 'npm', 'yarn'].map((tool) => __awaiter(this, void 0, void 0, function* () {
-            const pathTool = yield io.which(tool, false);
+            const output = yield getToolVersion(tool, ['--version']);
-            const output = pathTool ? yield getToolVersion(tool, ['--version']) : '';
             return { tool, output };
         }));
         const tools = yield Promise.all(promises);

dist/setup/index.js

@@ -93110,11 +93110,7 @@ class BaseDistribution {
         const fileName = this.osPlat == 'win32'
             ? `node-v${version}-win-${osArch}`
             : `node-v${version}-${this.osPlat}-${osArch}`;
-        const urlFileName = this.osPlat == 'win32'
+        const urlFileName = this.osPlat == 'win32' ? `${fileName}.7z` : `${fileName}.tar.gz`;
-            ? this.nodeInfo.arch === 'arm64'
-                ? `${fileName}.zip`
-                : `${fileName}.7z`
-            : `${fileName}.tar.gz`;
         const initialUrl = this.getDistributionUrl();
         const url = `${initialUrl}/v${version}/${urlFileName}`;
         return {
@@ -93198,23 +93194,10 @@ class BaseDistribution {
             let extPath;
             info = info || {}; // satisfy compiler, never null when reaches here
             if (this.osPlat == 'win32') {
-                const extension = this.nodeInfo.arch === 'arm64' ? '.zip' : '.7z';
+                const _7zPath = path.join(__dirname, '../..', 'externals', '7zr.exe');
-                // Rename archive to add extension because after downloading
+                extPath = yield tc.extract7z(downloadPath, undefined, _7zPath);
-                // archive does not contain extension type and it leads to some issues
-                // on Windows runners without PowerShell Core.
-                //
-                // For default PowerShell Windows it should contain extension type to unpack it.
-                if (extension === '.zip') {
-                    const renamedArchive = `${downloadPath}.zip`;
-                    fs_1.default.renameSync(downloadPath, renamedArchive);
-                    extPath = yield tc.extractZip(renamedArchive);
-                }
-                else {
-                    const _7zPath = path.join(__dirname, '../..', 'externals', '7zr.exe');
-                    extPath = yield tc.extract7z(downloadPath, undefined, _7zPath);
-                }
                 // 7z extracts to folder matching file name
-                const nestedPath = path.join(extPath, path.basename(info.fileName, extension));
+                const nestedPath = path.join(extPath, path.basename(info.fileName, '.7z'));
                 if (fs_1.default.existsSync(nestedPath)) {
                     extPath = nestedPath;
                 }
@@ -93246,12 +93229,7 @@ class BaseDistribution {
                 dataFileName = `osx-${osArch}-tar`;
                 break;
             case 'win32':
-                if (this.nodeInfo.arch === 'arm64') {
+                dataFileName = `win-${osArch}-exe`;
-                    dataFileName = `win-${osArch}-zip`;
-                }
-                else {
-                    dataFileName = `win-${osArch}-exe`;
-                }
                 break;
             default:
                 throw new Error(`Unexpected OS '${this.osPlat}'`);
@@ -93805,7 +93783,6 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.unique = exports.printEnvDetailsAndSetOutput = exports.getNodeVersionFromFile = void 0;
 const core = __importStar(__nccwpck_require__(2186));
 const exec = __importStar(__nccwpck_require__(1514));
-const io = __importStar(__nccwpck_require__(7436));
 const fs_1 = __importDefault(__nccwpck_require__(7147));
 const path_1 = __importDefault(__nccwpck_require__(1017));
 function getNodeVersionFromFile(versionFilePath) {
@@ -93857,8 +93834,7 @@ function printEnvDetailsAndSetOutput() {
     return __awaiter(this, void 0, void 0, function* () {
         core.startGroup('Environment details');
         const promises = ['node', 'npm', 'yarn'].map((tool) => __awaiter(this, void 0, void 0, function* () {
-            const pathTool = yield io.which(tool, false);
+            const output = yield getToolVersion(tool, ['--version']);
-            const output = pathTool ? yield getToolVersion(tool, ['--version']) : '';
             return { tool, output };
         }));
         const tools = yield Promise.all(promises);

src/distributions/base-distribution.ts

@@ -112,11 +112,7 @@ export default abstract class BaseDistribution {
         ? `node-v${version}-win-${osArch}`
         : `node-v${version}-${this.osPlat}-${osArch}`;
     const urlFileName: string =
-      this.osPlat == 'win32'
+      this.osPlat == 'win32' ? `${fileName}.7z` : `${fileName}.tar.gz`;
-        ? this.nodeInfo.arch === 'arm64'
-          ? `${fileName}.zip`
-          : `${fileName}.7z`
-        : `${fileName}.tar.gz`;
     const initialUrl = this.getDistributionUrl();
     const url = `${initialUrl}/v${version}/${urlFileName}`;
 
@@ -219,24 +215,12 @@ export default abstract class BaseDistribution {
     let extPath: string;
     info = info || ({} as INodeVersionInfo); // satisfy compiler, never null when reaches here
     if (this.osPlat == 'win32') {
-      const extension = this.nodeInfo.arch === 'arm64' ? '.zip' : '.7z';
+      const _7zPath = path.join(__dirname, '../..', 'externals', '7zr.exe');
-      // Rename archive to add extension because after downloading
+      extPath = await tc.extract7z(downloadPath, undefined, _7zPath);
-      // archive does not contain extension type and it leads to some issues
-      // on Windows runners without PowerShell Core.
-      //
-      // For default PowerShell Windows it should contain extension type to unpack it.
-      if (extension === '.zip') {
-        const renamedArchive = `${downloadPath}.zip`;
-        fs.renameSync(downloadPath, renamedArchive);
-        extPath = await tc.extractZip(renamedArchive);
-      } else {
-        const _7zPath = path.join(__dirname, '../..', 'externals', '7zr.exe');
-        extPath = await tc.extract7z(downloadPath, undefined, _7zPath);
-      }
       // 7z extracts to folder matching file name
       const nestedPath = path.join(
         extPath,
-        path.basename(info.fileName, extension)
+        path.basename(info.fileName, '.7z')
       );
       if (fs.existsSync(nestedPath)) {
         extPath = nestedPath;
@@ -276,11 +260,7 @@ export default abstract class BaseDistribution {
         dataFileName = `osx-${osArch}-tar`;
         break;
       case 'win32':
-        if (this.nodeInfo.arch === 'arm64') {
+        dataFileName = `win-${osArch}-exe`;
-          dataFileName = `win-${osArch}-zip`;
-        } else {
-          dataFileName = `win-${osArch}-exe`;
-        }
         break;
       default:
         throw new Error(`Unexpected OS '${this.osPlat}'`);

src/util.ts

@@ -1,6 +1,5 @@
 import * as core from '@actions/core';
 import * as exec from '@actions/exec';
-import * as io from '@actions/io';
 
 import fs from 'fs';
 import path from 'path';
@@ -62,9 +61,9 @@ export function getNodeVersionFromFile(versionFilePath: string): string | null {
 
 export async function printEnvDetailsAndSetOutput() {
   core.startGroup('Environment details');
+
   const promises = ['node', 'npm', 'yarn'].map(async tool => {
-    const pathTool = await io.which(tool, false);
+    const output = await getToolVersion(tool, ['--version']);
-    const output = pathTool ? await getToolVersion(tool, ['--version']) : '';
 
     return {tool, output};
   });