check failure fix

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.62.0 to 8.24.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.24.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/eslint-compact.json

@@ -4,7 +4,7 @@
             "owner": "eslint-compact",
             "pattern": [
                 {
-                    "regexp": "^(.+):\\sline\\s(\\d+),\\scol\\s(\\d+),\\s([Ee]rror|[Ww]arning|[Ii]nfo)\\s-\\s(.+)\\s\\((.+)\\)$",
+                    "regexp": "^(.+):\\sline\\s(\\d+),\\scol\\s(\\d+),\\s(Error|Warning|Info)\\s-\\s(.+)\\s\\((.+)\\)$",
                     "file": 1,
                     "line": 2,
                     "column": 3,

.github/eslint-stylish.json

@@ -4,7 +4,7 @@
             "owner": "eslint-stylish",
             "pattern": [
                 {
-                    "regexp": "^\\s*([^\\s].*)$",
+                    "regexp": "^([^\\s].*)$",
                     "file": 1
                 },
                 {

README.md

@@ -76,21 +76,6 @@ See [action.yml](action.yml)
     # Set always-auth option in npmrc file.
     # Default: ''
     always-auth: ''
-
-    # Optional mirror to download binaries from.
-    # Artifacts need to match the official Node.js
-    # Example:
-    # V8 Canaray Build: <mirror_url>/download/v8-canary
-    # RC Build: <mirror_url>/download/rc
-    # Official: Build <mirror_url>/dist
-    # Nightly build: <mirror_url>/download/nightly
-    # Default: ''
-    mirror: ''
-
-    # Optional mirror token.
-    # The token will be used as a bearer token in the Authorization header
-    # Default: ''
-    mirror-token: ''
 ```
 <!-- end usage -->
 

__tests__/canary-installer.test.ts

@@ -498,70 +498,6 @@ describe('setup-node', () => {
         );
       }
     );
-
-    it.each([
-      [
-        '20.0.0-v8-canary',
-        '20.0.0-v8-canary20221103f7e2421e91',
-        '20.0.0-v8-canary20221030fefe1c0879',
-        'https://my_mirror.org/download/v8-canary/v20.0.0-v8-canary20221103f7e2421e91/node-v20.0.0-v8-canary20221103f7e2421e91-linux-x64.tar.gz'
-      ],
-      [
-        '20-v8-canary',
-        '20.0.0-v8-canary20221103f7e2421e91',
-        '20.0.0-v8-canary20221030fefe1c0879',
-        'https://my_mirror.org/download/v8-canary/v20.0.0-v8-canary20221103f7e2421e91/node-v20.0.0-v8-canary20221103f7e2421e91-linux-x64.tar.gz'
-      ],
-      [
-        '19.0.0-v8-canary',
-        '19.0.0-v8-canary202210187d6960f23f',
-        '19.0.0-v8-canary202210172ec229fc56',
-        'https://my_mirror.org/download/v8-canary/v19.0.0-v8-canary202210187d6960f23f/node-v19.0.0-v8-canary202210187d6960f23f-linux-x64.tar.gz'
-      ],
-      [
-        '19-v8-canary',
-        '19.0.0-v8-canary202210187d6960f23f',
-        '19.0.0-v8-canary202210172ec229fc56',
-        'https://my_mirror.org/download/v8-canary/v19.0.0-v8-canary202210187d6960f23f/node-v19.0.0-v8-canary202210187d6960f23f-linux-x64.tar.gz'
-      ]
-    ])(
-      'get %s version from dist if check-latest is true',
-      async (input, expectedVersion, foundVersion, expectedUrl) => {
-        const foundToolPath = path.normalize(`/cache/node/${foundVersion}/x64`);
-        const toolPath = path.normalize(`/cache/node/${expectedVersion}/x64`);
-
-        inputs['node-version'] = input;
-        inputs['check-latest'] = 'true';
-        os['arch'] = 'x64';
-        os['platform'] = 'linux';
-        inputs['mirror'] = 'https://my_mirror.org';
-        inputs['mirror-token'] = 'faketoken';
-
-        findSpy.mockReturnValue(foundToolPath);
-        findAllVersionsSpy.mockReturnValue([
-          '20.0.0-v8-canary20221030fefe1c0879',
-          '19.0.0-v8-canary202210172ec229fc56',
-          '20.0.0-v8-canary2022102310ff1e5a8d'
-        ]);
-        dlSpy.mockImplementation(async () => '/some/temp/path');
-        exSpy.mockImplementation(async () => '/some/other/temp/path');
-        cacheSpy.mockImplementation(async () => toolPath);
-
-        // act
-        await main.run();
-
-        // assert
-        expect(findAllVersionsSpy).toHaveBeenCalled();
-        expect(logSpy).toHaveBeenCalledWith(
-          `Acquiring ${expectedVersion} - ${os.arch} from ${expectedUrl}`
-        );
-        expect(logSpy).toHaveBeenCalledWith('Extracting ...');
-        expect(logSpy).toHaveBeenCalledWith('Adding to the cache ...');
-        expect(cnSpy).toHaveBeenCalledWith(
-          `::add-path::${path.join(toolPath, 'bin')}${osm.EOL}`
-        );
-      }
-    );
   });
 
   describe('setup-node v8 canary tests', () => {

__tests__/nightly-installer.test.ts

@@ -315,7 +315,7 @@ describe('setup-node', () => {
     await main.run();
 
     workingUrls.forEach(url => {
-      expect(dlSpy).toHaveBeenCalledWith(url, undefined, undefined);
+      expect(dlSpy).toHaveBeenCalledWith(url);
     });
     expect(cnSpy).toHaveBeenCalledWith(`::add-path::${toolPath}${osm.EOL}`);
   });
@@ -449,54 +449,6 @@ describe('setup-node', () => {
     }
   }, 100000);
 
-  it('acquires specified architecture of node from mirror', async () => {
-    for (const {arch, version, osSpec} of [
-      {
-        arch: 'x86',
-        version: '18.0.0-nightly202110204cb3e06ed8',
-        osSpec: 'win32'
-      },
-      {
-        arch: 'x86',
-        version: '20.0.0-nightly2022101987cdf7d412',
-        osSpec: 'win32'
-      }
-    ]) {
-      os.platform = osSpec;
-      os.arch = arch;
-      const fileExtension = os.platform === 'win32' ? '7z' : 'tar.gz';
-      const platform = {
-        linux: 'linux',
-        darwin: 'darwin',
-        win32: 'win'
-      }[os.platform];
-
-      inputs['node-version'] = version;
-      inputs['architecture'] = arch;
-      inputs['always-auth'] = false;
-      inputs['token'] = 'faketoken';
-      inputs['mirror'] = 'https://my-mirror.org';
-      inputs['mirror-token'] = 'my-mirror-token';
-
-      const expectedUrl = `https://my-mirror.org/download/nightly/v${version}/node-v${version}-${platform}-${arch}.${fileExtension}`;
-
-      // ... but not in the local cache
-      findSpy.mockImplementation(() => '');
-      findAllVersionsSpy.mockImplementation(() => []);
-
-      dlSpy.mockImplementation(async () => '/some/temp/path');
-      const toolPath = path.normalize(`/cache/node/${version}/${arch}`);
-      exSpy.mockImplementation(async () => '/some/other/temp/path');
-      cacheSpy.mockImplementation(async () => toolPath);
-
-      await main.run();
-      expect(dlSpy).toHaveBeenCalled();
-      expect(logSpy).toHaveBeenCalledWith(
-        `Acquiring ${version} - ${arch} from ${expectedUrl}`
-      );
-    }
-  }, 100000);
-
   describe('nightly versions', () => {
     it.each([
       [

__tests__/official-installer.test.ts

@@ -282,43 +282,6 @@ describe('setup-node', () => {
     expect(cnSpy).toHaveBeenCalledWith(`::add-path::${expPath}${osm.EOL}`);
   });
 
-  it('falls back to a version from node dist from mirror', async () => {
-    os.platform = 'linux';
-    os.arch = 'x64';
-
-    // a version which is not in the manifest but is in node dist
-    const versionSpec = '11.15.0';
-    const mirror = 'https://my_mirror_url';
-    inputs['node-version'] = versionSpec;
-    inputs['always-auth'] = false;
-    inputs['token'] = 'faketoken';
-    inputs['mirror'] = mirror;
-    inputs['mirror-token'] = 'faketoken';
-
-    // ... but not in the local cache
-    findSpy.mockImplementation(() => '');
-
-    dlSpy.mockImplementation(async () => '/some/temp/path');
-    const toolPath = path.normalize('/cache/node/11.15.0/x64');
-    exSpy.mockImplementation(async () => '/some/other/temp/path');
-    cacheSpy.mockImplementation(async () => toolPath);
-
-    await main.run();
-
-    const expPath = path.join(toolPath, 'bin');
-
-    expect(getManifestSpy).toHaveBeenCalled();
-    expect(logSpy).toHaveBeenCalledWith(
-      `Attempting to download ${versionSpec}...`
-    );
-    expect(logSpy).toHaveBeenCalledWith(
-      `Not found in manifest. Falling back to download directly from ${mirror}`
-    );
-    expect(dlSpy).toHaveBeenCalled();
-    expect(exSpy).toHaveBeenCalled();
-    expect(cnSpy).toHaveBeenCalledWith(`::add-path::${expPath}${osm.EOL}`);
-  });
-
   it('falls back to a version from node dist', async () => {
     os.platform = 'linux';
     os.arch = 'x64';
@@ -865,46 +828,4 @@ describe('setup-node', () => {
       }
     );
   });
-
-  it('acquires specified architecture of node from mirror', async () => {
-    for (const {arch, version, osSpec} of [
-      {arch: 'x86', version: '12.16.2', osSpec: 'win32'},
-      {arch: 'x86', version: '14.0.0', osSpec: 'win32'}
-    ]) {
-      os.platform = osSpec;
-      os.arch = arch;
-      const fileExtension = os.platform === 'win32' ? '7z' : 'tar.gz';
-      const platform = {
-        linux: 'linux',
-        darwin: 'darwin',
-        win32: 'win'
-      }[os.platform];
-
-      inputs['node-version'] = version;
-      inputs['architecture'] = arch;
-      inputs['always-auth'] = false;
-      inputs['token'] = 'faketoken';
-      inputs['mirror'] = 'https://my_mirror_url';
-      inputs['mirror-token'] = 'faketoken';
-
-      const expectedUrl =
-        arch === 'x64'
-          ? `https://github.com/actions/node-versions/releases/download/${version}/node-${version}-${platform}-${arch}.zip`
-          : `https://my_mirror_url/dist/v${version}/node-v${version}-${platform}-${arch}.${fileExtension}`;
-
-      // ... but not in the local cache
-      findSpy.mockImplementation(() => '');
-
-      dlSpy.mockImplementation(async () => '/some/temp/path');
-      const toolPath = path.normalize(`/cache/node/${version}/${arch}`);
-      exSpy.mockImplementation(async () => '/some/other/temp/path');
-      cacheSpy.mockImplementation(async () => toolPath);
-
-      await main.run();
-      expect(dlSpy).toHaveBeenCalled();
-      expect(logSpy).toHaveBeenCalledWith(
-        `Acquiring ${version} - ${arch} from ${expectedUrl}`
-      );
-    }
-  }, 100000);
 });

action.yml

@@ -25,10 +25,6 @@ inputs:
     description: 'Used to specify a package manager for caching in the default directory. Supported values: npm, yarn, pnpm.'
   cache-dependency-path:
     description: 'Used to specify the path to a dependency file: package-lock.json, yarn.lock, etc. Supports wildcards or a list of file names for caching multiple dependencies.'
-  mirror:
-    description: 'Used to specify an alternative mirror to downlooad Node.js binaries from'
-  mirror-token:
-    description: 'The token used as Authorization header when fetching from the mirror'
 # TODO: add input to control forcing to pull from cloud or dist.
 #       escape valve for someone having issues or needing the absolute latest which isn't cached yet
 outputs:

docs/advanced-usage.md

@@ -418,18 +418,3 @@ Please refer to the [Ensuring workflow access to your package - Configuring a pa
 
 ### always-auth input
 The always-auth input sets `always-auth=true` in .npmrc file. With this option set [npm](https://docs.npmjs.com/cli/v6/using-npm/config#always-auth)/yarn sends the authentication credentials when making a request to the registries.
-
-## Use private mirror
-
-It is possible to use a private mirror hosting Node.js binaries. This mirror must be a full mirror of the official Node.js distribution.
-The mirror URL can be set using the `mirror` input.
-It is possible to specify a token to authenticate with the mirror using the `mirror-token` input.
-The token will be passed as a bearer token in the `Authorization` header.
-
-```yaml
-- uses: actions/setup-node@v4
-  with:
-    node-version: '14.x'
-    mirror: 'https://nodejs.org/dist'
-    mirror-token: 'your-mirror-token'
-```

package.json

@@ -25,14 +25,14 @@
   "author": "GitHub",
   "license": "MIT",
   "dependencies": {
-    "@actions/cache": "^4.0.3",
+    "@actions/cache": "^4.0.2",
     "@actions/core": "^1.11.1",
     "@actions/exec": "^1.1.1",
-    "@actions/github": "^6.0.1",
+    "@actions/github": "^5.1.1",
     "@actions/glob": "^0.5.0",
     "@actions/http-client": "^2.2.1",
     "@actions/io": "^1.0.2",
-    "@actions/tool-cache": "^2.0.2",
+    "@actions/tool-cache": "^2.0.1",
     "semver": "^7.6.3",
     "uuid": "^9.0.1"
   },
@@ -40,12 +40,12 @@
     "@types/jest": "^29.5.14",
     "@types/node": "^20.11.25",
     "@types/semver": "^7.5.8",
-    "@typescript-eslint/eslint-plugin": "^5.54.0",
+    "@typescript-eslint/eslint-plugin": "^8.26.1",
-    "@typescript-eslint/parser": "^8.34.1",
+    "@typescript-eslint/parser": "^8.26.1",
-    "@vercel/ncc": "^0.38.3",
+    "@vercel/ncc": "^0.38.0",
     "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.6.0",
-    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jest": "^28.11.0",
     "eslint-plugin-node": "^11.1.0",
     "jest": "^29.7.0",
     "jest-circus": "^29.7.0",

src/distributions/base-distribution.ts

@@ -24,7 +24,7 @@ export default abstract class BaseDistribution {
     });
   }
 
-  protected abstract getDistributionUrl(mirror: string): string;
+  protected abstract getDistributionUrl(): string;
 
   public async setupNodeJs() {
     let nodeJsVersions: INodeVersion[] | undefined;
@@ -97,19 +97,10 @@ export default abstract class BaseDistribution {
   }
 
   protected async getNodeJsVersions(): Promise<INodeVersion[]> {
-    const initialUrl = this.getDistributionUrl(this.nodeInfo.mirror);
+    const initialUrl = this.getDistributionUrl();
     const dataUrl = `${initialUrl}/index.json`;
 
-    const headers = {};
+    const response = await this.httpClient.getJson<INodeVersion[]>(dataUrl);
-
-    if (this.nodeInfo.mirrorToken) {
-      headers['Authorization'] = `Bearer ${this.nodeInfo.mirrorToken}`;
-    }
-
-    const response = await this.httpClient.getJson<INodeVersion[]>(
-      dataUrl,
-      headers
-    );
     return response.result || [];
   }
 
@@ -126,7 +117,7 @@ export default abstract class BaseDistribution {
           ? `${fileName}.zip`
           : `${fileName}.7z`
         : `${fileName}.tar.gz`;
-    const initialUrl = this.getDistributionUrl(this.nodeInfo.mirror);
+    const initialUrl = this.getDistributionUrl();
     const url = `${initialUrl}/v${version}/${urlFileName}`;
 
     return <INodeVersionInfo>{
@@ -143,11 +134,7 @@ export default abstract class BaseDistribution {
       `Acquiring ${info.resolvedVersion} - ${info.arch} from ${info.downloadUrl}`
     );
     try {
-      downloadPath = await tc.downloadTool(
+      downloadPath = await tc.downloadTool(info.downloadUrl);
-        info.downloadUrl,
-        undefined,
-        this.nodeInfo.mirrorToken
-      );
     } catch (err) {
       if (
         err instanceof tc.HTTPError &&
@@ -181,7 +168,7 @@ export default abstract class BaseDistribution {
     version: string,
     arch: string = os.arch()
   ): Promise<string> {
-    const initialUrl = this.getDistributionUrl(this.nodeInfo.mirror);
+    const initialUrl = this.getDistributionUrl();
     const osArch: string = this.translateArchToDistUrl(arch);
 
     // Create temporary folder to download to
@@ -198,34 +185,18 @@ export default abstract class BaseDistribution {
 
       core.info(`Downloading only node binary from ${exeUrl}`);
 
-      const exePath = await tc.downloadTool(
+      const exePath = await tc.downloadTool(exeUrl);
-        exeUrl,
-        undefined,
-        this.nodeInfo.mirrorToken
-      );
       await io.cp(exePath, path.join(tempDir, 'node.exe'));
-      const libPath = await tc.downloadTool(
+      const libPath = await tc.downloadTool(libUrl);
-        libUrl,
-        undefined,
-        this.nodeInfo.mirrorToken
-      );
       await io.cp(libPath, path.join(tempDir, 'node.lib'));
     } catch (err) {
       if (err instanceof tc.HTTPError && err.httpStatusCode == 404) {
         exeUrl = `${initialUrl}/v${version}/node.exe`;
         libUrl = `${initialUrl}/v${version}/node.lib`;
 
-        const exePath = await tc.downloadTool(
+        const exePath = await tc.downloadTool(exeUrl);
-          exeUrl,
-          undefined,
-          this.nodeInfo.mirrorToken
-        );
         await io.cp(exePath, path.join(tempDir, 'node.exe'));
-        const libPath = await tc.downloadTool(
+        const libPath = await tc.downloadTool(libUrl);
-          libUrl,
-          undefined,
-          this.nodeInfo.mirrorToken
-        );
         await io.cp(libPath, path.join(tempDir, 'node.lib'));
       } else {
         throw err;

src/distributions/base-models.ts

@@ -4,8 +4,6 @@ export interface NodeInputs {
   auth?: string;
   checkLatest: boolean;
   stable: boolean;
-  mirror: string;
-  mirrorToken: string;
 }
 
 export interface INodeVersionInfo {

src/distributions/nightly/nightly_builds.ts

@@ -7,8 +7,7 @@ export default class NightlyNodejs extends BasePrereleaseNodejs {
     super(nodeInfo);
   }
 
-  protected getDistributionUrl(mirror: string): string {
+  protected getDistributionUrl(): string {
-    const url = mirror || 'https://nodejs.org';
+    return 'https://nodejs.org/download/nightly';
-    return `${url}/download/nightly`;
   }
 }

src/distributions/official_builds/official_builds.ts

@@ -84,7 +84,7 @@ export default class OfficialBuilds extends BaseDistribution {
         downloadPath = await tc.downloadTool(
           versionInfo.downloadUrl,
           undefined,
-          this.nodeInfo.mirror ? this.nodeInfo.mirrorToken : this.nodeInfo.auth
+          this.nodeInfo.auth
         );
 
         if (downloadPath) {
@@ -96,9 +96,7 @@ export default class OfficialBuilds extends BaseDistribution {
         }
       } else {
         core.info(
-          `Not found in manifest. Falling back to download directly from ${
+          'Not found in manifest. Falling back to download directly from Node'
-            this.nodeInfo.mirror || 'Node'
-          }`
         );
       }
     } catch (err) {
@@ -178,9 +176,8 @@ export default class OfficialBuilds extends BaseDistribution {
     return version;
   }
 
-  protected getDistributionUrl(mirror: string): string {
+  protected getDistributionUrl(): string {
-    const url = mirror || 'https://nodejs.org';
+    return `https://nodejs.org/dist`;
-    return `${url}/dist`;
   }
 
   private getManifest(): Promise<tc.IToolRelease[]> {
@@ -188,7 +185,7 @@ export default class OfficialBuilds extends BaseDistribution {
     return tc.getManifestFromRepo(
       'actions',
       'node-versions',
-      this.nodeInfo.mirror ? this.nodeInfo.mirrorToken : this.nodeInfo.auth,
+      this.nodeInfo.auth,
       'main'
     );
   }

src/distributions/rc/rc_builds.ts

@@ -6,8 +6,7 @@ export default class RcBuild extends BaseDistribution {
     super(nodeInfo);
   }
 
-  getDistributionUrl(mirror: string): string {
+  getDistributionUrl(): string {
-    const url = mirror || 'https://nodejs.org';
+    return 'https://nodejs.org/download/rc';
-    return `${url}/download/rc`;
   }
 }

src/distributions/v8-canary/canary_builds.ts

@@ -7,8 +7,7 @@ export default class CanaryBuild extends BasePrereleaseNodejs {
     super(nodeInfo);
   }
 
-  protected getDistributionUrl(mirror: string): string {
+  protected getDistributionUrl(): string {
-    const url = mirror || 'https://nodejs.org';
+    return 'https://nodejs.org/download/v8-canary';
-    return `${url}/download/v8-canary`;
   }
 }

src/main.ts

@@ -36,8 +36,6 @@ export async function run() {
     if (version) {
       const token = core.getInput('token');
       const auth = !token ? undefined : `token ${token}`;
-      const mirror = core.getInput('mirror');
-      const mirrorToken = core.getInput('mirror-token');
       const stable =
         (core.getInput('stable') || 'true').toUpperCase() === 'TRUE';
       const checkLatest =
@@ -47,9 +45,7 @@ export async function run() {
         checkLatest,
         auth,
         stable,
-        arch,
+        arch
-        mirror,
-        mirrorToken
       };
       const nodeDistribution = getNodejsDistribution(nodejsInfo);
       await nodeDistribution.setupNodeJs();