From 54d78531ccff74a24adc588d09017595f3c7b602 Mon Sep 17 00:00:00 2001 From: Christian Holtje Date: Sat, 10 Oct 2020 01:12:48 -0400 Subject: [PATCH 1/2] Use SuperLinter instead of only shellcheck --- .github/workflows/linter.yml | 52 ++++++++++++++++++++++++++++++++ .github/workflows/shellcheck.yml | 12 -------- 2 files changed, 52 insertions(+), 12 deletions(-) create mode 100644 .github/workflows/linter.yml delete mode 100644 .github/workflows/shellcheck.yml diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml new file mode 100644 index 0000000..4fb55c8 --- /dev/null +++ b/.github/workflows/linter.yml @@ -0,0 +1,52 @@ +--- +########################### +########################### +## Linter GitHub Actions ## +########################### +########################### +name: Lint Code Base + +# +# Documentation: +# https://help.github.com/en/articles/workflow-syntax-for-github-actions +# + +############################# +# Start the job on all push # +############################# +on: + push: + branches-ignore: [master] + # Remove the line above to run when pushing to master + pull_request: + branches: [master] + +############### +# Set the Job # +############### +jobs: + build: + # Name the Job + name: Lint Code Base + # Set the agent to run on + runs-on: ubuntu-latest + + ################## + # Load all steps # + ################## + steps: + ########################## + # Checkout the code base # + ########################## + - name: Checkout Code + uses: actions/checkout@v2 + + ################################ + # Run Linter against code base # + ################################ + - name: Lint Code Base + uses: github/super-linter@v3 + env: + VALIDATE_ALL_CODEBASE: false + DEFAULT_BRANCH: master + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml deleted file mode 100644 index b9d61aa..0000000 --- a/.github/workflows/shellcheck.yml +++ /dev/null @@ -1,12 +0,0 @@ -name: Shellcheck - -on: push - -jobs: - shellcheck: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v1 - - - name: shellcheck - uses: ludeeus/action-shellcheck@0.1.0 From 16d2bf88fd84621db3aefdae17f44f89fc977729 Mon Sep 17 00:00:00 2001 From: Stefan Zweifel Date: Sat, 10 Oct 2020 16:17:58 +0200 Subject: [PATCH 2/2] Remove Comments from Workflow --- .github/workflows/linter.yml | 38 ++---------------------------------- 1 file changed, 2 insertions(+), 36 deletions(-) diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index 4fb55c8..23329dd 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -1,52 +1,18 @@ ---- -########################### -########################### -## Linter GitHub Actions ## -########################### -########################### name: Lint Code Base +on: push -# -# Documentation: -# https://help.github.com/en/articles/workflow-syntax-for-github-actions -# - -############################# -# Start the job on all push # -############################# -on: - push: - branches-ignore: [master] - # Remove the line above to run when pushing to master - pull_request: - branches: [master] - -############### -# Set the Job # -############### jobs: build: - # Name the Job name: Lint Code Base - # Set the agent to run on runs-on: ubuntu-latest - ################## - # Load all steps # - ################## steps: - ########################## - # Checkout the code base # - ########################## - name: Checkout Code uses: actions/checkout@v2 - ################################ - # Run Linter against code base # - ################################ - name: Lint Code Base uses: github/super-linter@v3 env: VALIDATE_ALL_CODEBASE: false DEFAULT_BRANCH: master - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}