suyiiyii/yq
1
0
Fork 0
mirror of https://github.com/mikefarah/yq.git synced 2026-07-08 14:55:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use slices.Equal to simplify code

Browse Source 
Signed-off-by: houpo-bob <houpocun@outlook.com>
This commit is contained in:
houpo-bob 2025-07-25 15:36:15 +08:00
parent f03c9dc599
commit 17b296f24b
1 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
cmd/utils_test.go
View File

@ -3,6 +3,7 @@ package cmd
import (
"fmt"
"os"
"slices"
"strings"
"testing"
@ -191,7 +192,7 @@ func TestProcessArgs(t *testing.T) {
t.Errorf("processArgs() expression = %v, want %v", expr, tt.expectedExpr)
}
if !stringsEqual(args, tt.expectedArgs) {
if !slices.Equal(args, tt.expectedArgs) {
t.Errorf("processArgs() args = %v, want %v", args, tt.expectedArgs)
}
})
@ -599,7 +600,7 @@ func TestInitCommand(t *testing.T) {
if expr != tt.expectExpr {
t.Errorf("initCommand() expr = %v, want %v", expr, tt.expectExpr)
}
if !stringsEqual(args, tt.expectArgs) {
if !slices.Equal(args, tt.expectArgs) {
t.Errorf("initCommand() args = %v, want %v", args, tt.expectArgs)
}
})
@ -636,7 +637,7 @@ func TestProcessArgsWithExpressionFile(t *testing.T) {
}
expectedArgs := []string{"file1"}
if !stringsEqual(args, expectedArgs) {
if !slices.Equal(args, expectedArgs) {
t.Errorf("processArgs() args = %v, want %v", args, expectedArgs)
}
}
@ -763,7 +764,7 @@ func TestMaybeFileWithDirectory(t *testing.T) {
func TestProcessStdInArgsWithDash(t *testing.T) {
args := []string{"-", "file1"}
result := processStdInArgs(args)
if !stringsEqual(result, args) {
if !slices.Equal(result, args) {
t.Errorf("processStdInArgs() = %v, want %v", result, args)
}
}
@ -810,7 +811,7 @@ func TestProcessArgsWithYqFileExtension(t *testing.T) {
}
expectedArgs := []string{}
if !stringsEqual(args, expectedArgs) {
if !slices.Equal(args, expectedArgs) {
t.Errorf("processArgs() args = %v, want %v", args, expectedArgs)
}
}
@ -905,19 +906,6 @@ func (f *mockBoolFlag) Type() string {
return "bool"
}
// Helper function to compare string slices
func stringsEqual(a, b []string) bool {
if len(a) != len(b) {
return false
}
for i := range a {
if a[i] != b[i] {
return false
}
}
return true
}
func TestSetupColors(t *testing.T) {
tests := []struct {
name string