suyiiyii/yq
1
0
Fork 0
mirror of https://github.com/mikefarah/yq.git synced 2024-11-13 22:38:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip and warn when interpolating strings and theres a unclosed bracket #2083

Browse Source
This commit is contained in:
Mike Farah 2024-06-29 15:20:07 +10:00
parent 0b7d4b799c
commit 28646c7b50
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/yqlib/operator_strings.go
View File

@ -102,7 +102,8 @@ func interpolate(d *dataTreeNavigator, context Context, str string) (string, err
} }
} }
if inExpression { if inExpression {
return "", fmt.Errorf("unclosed interpolation string \\(") log.Warning("unclosed interpolation string, skipping interpolation")
return str, nil
} }
return sb.String(), nil return sb.String(), nil
} }

24
pkg/yqlib/operator_strings_test.go
View File

@ -66,18 +66,22 @@ var stringsOperatorScenarios = []expressionScenario{
}, },
}, },
{ {
skipDoc: true, skipDoc: true,
description: "Interpolation - unclosed interpolation string", description: "Interpolation - unclosed interpolation string",
document: `value: things`, document: `value: things`,
expression: `"Hi \("`, expression: `"Hi \("`,
expectedError: "unclosed interpolation string \\(", expected: []string{
"D0, P[], (!!str)::Hi \\(\n",
},
}, },
{ {
skipDoc: true, skipDoc: true,
description: "Interpolation - unclosed interpolation string due to escape", description: "Interpolation - unclosed interpolation string due to escape",
document: `value: things`, document: `value: things`,
expression: `"Hi \(\)"`, expression: `"Hi \(\)"`,
expectedError: "unclosed interpolation string \\(", expected: []string{
"D0, P[], (!!str)::Hi \\(\\)\n",
},
}, },
{ {
description: "To up (upper) case", description: "To up (upper) case",