Merge 341e2524b9 into 17f66dc6c6

Agent-Logs-Url: https://github.com/mikefarah/yq/sessions/7c146762-d251-45fd-8555-2488f59fc57b

Co-authored-by: mikefarah <1151925+mikefarah@users.noreply.github.com>

pkg/yqlib/doc/operators/slice-array.md

@@ -110,11 +110,11 @@ country: Australia
 ```
 then
 ```bash
-yq '.country[4:]' sample.yml
+yq '.country[0:5]' sample.yml
 ```
 will output
 ```yaml
-ralia
+Austr
 ```
 
 ## Slicing strings - without the second number
@@ -126,11 +126,11 @@ country: Australia
 ```
 then
 ```bash
-yq '.country[0:5]' sample.yml
+yq '.country[5:]' sample.yml
 ```
 will output
 ```yaml
-Austr
+alia
 ```
 
 ## Slicing strings - without the first number

pkg/yqlib/operator_slice.go

@@ -16,7 +16,7 @@ func getSliceNumber(d *dataTreeNavigator, context Context, node *CandidateNode,
 	return parseInt(result.MatchingNodes.Front().Value.(*CandidateNode).Value)
 }
 
-func sliceStringNode(lhsNode *CandidateNode, firstNumber int, secondNumber int) (*CandidateNode, error) {
+func sliceStringNode(lhsNode *CandidateNode, firstNumber int, secondNumber int) *CandidateNode {
 	runes := []rune(lhsNode.Value)
 	length := len(runes)
 
@@ -45,7 +45,9 @@ func sliceStringNode(lhsNode *CandidateNode, firstNumber int, secondNumber int)
 	}
 
 	slicedString := string(runes[relativeFirstNumber:relativeSecondNumber])
-	return lhsNode.CreateReplacement(ScalarNode, "!!str", slicedString), nil
+	replacement := lhsNode.CreateReplacement(ScalarNode, lhsNode.Tag, slicedString)
+	replacement.Style = lhsNode.Style
+	return replacement
 }
 
 func sliceArrayOperator(d *dataTreeNavigator, context Context, expressionNode *ExpressionNode) (Context, error) {
@@ -70,11 +72,7 @@ func sliceArrayOperator(d *dataTreeNavigator, context Context, expressionNode *E
 		}
 
 		if lhsNode.Kind == ScalarNode && lhsNode.guessTagFromCustomType() == "!!str" {
-			slicedNode, err := sliceStringNode(lhsNode, firstNumber, secondNumber)
+			results.PushBack(sliceStringNode(lhsNode, firstNumber, secondNumber))
-			if err != nil {
-				return Context{}, err
-			}
-			results.PushBack(slicedNode)
 			continue
 		}
 
@@ -82,13 +80,24 @@ func sliceArrayOperator(d *dataTreeNavigator, context Context, expressionNode *E
 		if relativeFirstNumber < 0 {
 			relativeFirstNumber = len(lhsNode.Content) + firstNumber
 		}
+		if relativeFirstNumber < 0 {
+			relativeFirstNumber = 0
+		} else if relativeFirstNumber > len(lhsNode.Content) {
+			relativeFirstNumber = len(lhsNode.Content)
+		}
 
 		relativeSecondNumber := secondNumber
 		if relativeSecondNumber < 0 {
 			relativeSecondNumber = len(lhsNode.Content) + secondNumber
+		}
+		if relativeSecondNumber < 0 {
+			relativeSecondNumber = 0
 		} else if relativeSecondNumber > len(lhsNode.Content) {
 			relativeSecondNumber = len(lhsNode.Content)
 		}
+		if relativeSecondNumber < relativeFirstNumber {
+			relativeSecondNumber = relativeFirstNumber
+		}
 
 		log.Debugf("calculateIndicesToTraverse: slice from %v to %v", relativeFirstNumber, relativeSecondNumber)
 

pkg/yqlib/operator_slice_test.go

@@ -98,21 +98,37 @@ var sliceArrayScenarios = []expressionScenario{
 			"D0, P[], (!!seq)::- cat1\n",
 		},
 	},
+	{
+		skipDoc:    true,
+		document:   `[cat, dog, frog]`,
+		expression: `.[-100:]`,
+		expected: []string{
+			"D0, P[], (!!seq)::- cat\n- dog\n- frog\n",
+		},
+	},
+	{
+		skipDoc:    true,
+		document:   `[cat, dog, frog]`,
+		expression: `.[:-100]`,
+		expected: []string{
+			"D0, P[], (!!seq)::[]\n",
+		},
+	},
 	{
 		description: "Slicing strings",
 		document:    `country: Australia`,
-		expression:  `.country[4:]`,
+		expression:  `.country[0:5]`,
 		expected: []string{
-			"D0, P[country], (!!str)::ralia\n",
+			"D0, P[country], (!!str)::Austr\n",
 		},
 	},
 	{
 		description:    "Slicing strings - without the second number",
 		subdescription: "Finishes at the end of the string",
 		document:       `country: Australia`,
-		expression:     `.country[0:5]`,
+		expression:     `.country[5:]`,
 		expected: []string{
-			"D0, P[country], (!!str)::Austr\n",
+			"D0, P[country], (!!str)::alia\n",
 		},
 	},
 	{

project-words.txt

@@ -303,3 +303,4 @@ ralia
 Austr
 ustrali
 héllo
+alia