Revert "Fix for gosec rule G304 - sanitize filepaths"

This reverts commit ffb6cbf769.

pkg/yqlib/file_utils.go

@@ -3,7 +3,6 @@ package yqlib
 import (
 	"io"
 	"os"
-	"path/filepath"
 )
 
 func safelyRenameFile(from string, to string) {
@@ -26,7 +25,7 @@ func safelyRenameFile(from string, to string) {
 
 // thanks https://stackoverflow.com/questions/21060945/simple-way-to-copy-a-file-in-golang
 func copyFileContents(src, dst string) (err error) {
-	in, err := os.Open(filepath.Clean(src))
+	in, err := os.Open(src) // nolint gosec
 	if err != nil {
 		return err
 	}

pkg/yqlib/utils.go

@@ -5,7 +5,6 @@ import (
 	"container/list"
 	"io"
 	"os"
-	"path/filepath"
 
 	yaml "gopkg.in/yaml.v3"
 )
@@ -14,7 +13,7 @@ func readStream(filename string) (io.Reader, error) {
 	if filename == "-" {
 		return bufio.NewReader(os.Stdin), nil
 	} else {
-		return os.Open(filepath.Clean(filename))
+		return os.Open(filename) // nolint gosec
 	}
 }
 

test/utils.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"io/ioutil"
 	"os"
-	"path/filepath"
 	"reflect"
 	"strings"
 	"testing"
@@ -82,7 +81,7 @@ func WriteTempYamlFile(content string) string {
 }
 
 func ReadTempYamlFile(name string) string {
-	content, _ := ioutil.ReadFile(filepath.Clean(name))
+	content, _ := ioutil.ReadFile(name)
 	return string(content)
 }